Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScaleManager depends on "if (Null)" for isFullScreen #15

Open
ghost opened this issue Nov 2, 2014 · 0 comments
Open

ScaleManager depends on "if (Null)" for isFullScreen #15

ghost opened this issue Nov 2, 2014 · 0 comments

Comments

@ghost
Copy link

ghost commented Nov 2, 2014

In Dart, if (Null) and if (!Null) cause type errors.

ScaleManager depends on !isFullScreen evaluating like isFullScreen == Null in at least one line of code.

If the following lines of code are placed in the preload() method for a State implementer:

game.scale.scaleMode = ScaleManager.SHOW_ALL;
game.scale.setScreenSize(false);

A type error occurs at line 1108 in scale_manager.dart:
} else if (!this.isFullScreen) {

isFullScreen should probably be initialized to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants