Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Play's WebSocketClient in samples #65

Open
ignasi35 opened this issue Nov 22, 2019 · 2 comments
Open

Use Play's WebSocketClient in samples #65

ignasi35 opened this issue Nov 22, 2019 · 2 comments

Comments

@ignasi35
Copy link
Member

There are 4 different variants of WebSocket.java in variosu samples on play-samples:

MD5 (play-java-chatroom-example/test/controllers/WebSocketClient.java) = dd467ea512ecd3b5e4075a456cec6ec4
MD5 (play-java-websocket-example/test/controllers/WebSocketClient.java) = 4eabd6c7627da67173ecd32713b8547c
MD5 (play-scala-chatroom-example/test/controllers/WebSocketClient.java) = dd3b5b4c72dcaaed02e32d287aca6708
MD5 (play-scala-websocket-example/test/controllers/WebSocketClient.java) = ce5101be52df25961bc51ace1a213c96

Despite being different, it's very likely they can be merged and even promoted to Play's testkit tools.
@dwijnand dwijnand removed the triage label Nov 22, 2019
@dwijnand dwijnand changed the title Promote WebSocketClient to lagom itself Promote WebSocketClient to Play itself Nov 22, 2019
@ignasi35
Copy link
Member Author

Hmm, so lagom has one and Play already has another one too.

@octonato
Copy link
Member

So, let's change this to: Use Play's WebSocketClient in samples

@octonato octonato changed the title Promote WebSocketClient to Play itself Use Play's WebSocketClient in samples" Nov 28, 2019
@octonato octonato changed the title Use Play's WebSocketClient in samples" Use Play's WebSocketClient in samples Nov 28, 2019
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@marcospereira @mergify
Updated with template-control on 2019-01-04T17:13:23.812Z (playframew…
4561d17 
…ork#65)

/.travis.yml:
    wrote /.travis.yml
  **build.sbt:
    scalaVersion := "2.12.8"
  **/build.properties:
    sbt.version=1.2.8
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@marcospereira @mergify
Updated with template-control on 2019-01-04T17:13:23.621Z (playframew…
31231b1 
…ork#65)

/.travis.yml:
    wrote /.travis.yml
  **build.sbt:
    scalaVersion := "2.12.8"
  **/build.properties:
    sbt.version=1.2.8
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@marcospereira @mergify
Upgrade branch 2.6.x using TemplateControl (playframework#65)
bd73d44 
* Updated with template-control on 2019-01-04T17:13:23.850Z
  /.travis.yml:
    wrote /.travis.yml
  **build.sbt:
    scalaVersion := "2.12.8"
  **/build.properties:
    sbt.version=1.2.8

* Fix scalaVersion update
octonato added a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@octonato
Merge pull request playframework#65 from renatocaval/templatecontrol-…
3f8de1a 
…2.6.x

Upgrade branch 2.6.x using TemplateControl
octonato added a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@octonato
Merge pull request playframework#65 from renatocaval/templatecontrol-…
f8b1d89 
…2.6.x

Upgrade branch 2.6.x using TemplateControl
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-fileupload-example/2.6.x' int…
9d92639 
…o 2.6.x

* play-java-fileupload-example/2.6.x: (47 commits)
  Nest play-java-fileupload-example
  Updated with template-control on 2019-02-13T20:25:39.476Z (playframework#76)
  Upgrade branch 2.6.x using TemplateControl (playframework#74)
  Upgrade branch 2.6.x using TemplateControl (playframework#73)
  Upgrade branch 2.6.x using TemplateControl (playframework#72)
  Updated with template-control on 2019-01-08T14:44:42.021Z (playframework#70)
  Updated with template-control on 2019-01-04T17:13:23.621Z (playframework#65)
  Upgrade branch 2.6.x using TemplateControl (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Updated with template-control on 2018-09-11T20:14:49.858Z (playframework#60)
  Updated with template-control on 2018-08-20T20:37:13.644Z (playframework#59)
  Updated with template-control on 2018-07-19T01:58:54.727Z (playframework#57)
  Updated with template-control on 2018-07-16T18:38:45.481Z (playframework#56)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2018-05-27T23:54:09.370Z (playframework#54)
  Updated with template-control on 2018-04-06T19:34:57.877Z (playframework#52)
  Add explicit note on upload limit (playframework#51)
  Updated with template-control on 2018-03-02T18:56:28.047Z (playframework#49)
  Upgrade branch 2.6.x using TemplateControl (playframework#48)
  Fix cross build to sbt 1.1.0 (playframework#47)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-jpa-example/2.6.x' into 2.6.x
3d9fb36 
* play-java-jpa-example/2.6.x: (48 commits)
  Nest play-java-jpa-example
  Updated with template-control on 2019-02-13T20:25:39.298Z (playframework#87)
  Upgrade branch 2.6.x using TemplateControl (playframework#85)
  Upgrade branch 2.6.x using TemplateControl (playframework#84)
  Upgrade branch 2.6.x using TemplateControl (playframework#83)
  Updated with template-control on 2019-01-08T14:44:42.531Z (playframework#81)
  Updated with template-control on 2019-01-04T17:13:23.827Z (playframework#76)
  Upgrade branch 2.6.x using TemplateControl (playframework#71)
  Upgrade branch 2.6.x using TemplateControl (playframework#69)
  Updated with template-control on 2018-09-11T20:14:50.333Z (playframework#65)
  Updated with template-control on 2018-08-20T20:37:13.878Z (playframework#63)
  Updated with template-control on 2018-07-19T01:58:55.873Z (playframework#61)
  Updated with template-control on 2018-07-16T18:38:45.441Z (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  Updated with template-control on 2018-05-27T23:54:09.603Z (playframework#58)
  Updated with template-control on 2018-04-06T19:34:58.092Z (playframework#55)
  Updated with template-control on 2018-03-02T18:56:28.087Z (playframework#54)
  Upgrade branch 2.6.x using TemplateControl (playframework#53)
  Fix cross build to sbt 1.1.0 (playframework#52)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-rest-api-example/2.6.x' into …
90cb777 
…2.6.x

* play-java-rest-api-example/2.6.x: (61 commits)
  Nest play-java-rest-api-example
  Updated with template-control on 2019-02-13T20:25:39.721Z (playframework#81)
  Upgrade branch 2.6.x using TemplateControl (playframework#79)
  Updated with template-control on 2019-01-17T15:10:58.259Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:46.124Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.8"   **build.gradle:         playTest "io.gatling.highcharts:gatling-charts-highcharts:$gatlingVersion"   **build.gradle:         playTest "io.gatling:gatling-test-framework:$gatlingVersion"
  Upgrade branch 2.6.x using TemplateControl (playframework#74)
  Upgrade branch 2.6.x using TemplateControl (playframework#65)
  fixing wrong template-ctrl replacement
  Updated with template-control on 2018-11-29T16:03:57.787Z   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.7"   **/build.properties:     sbt.version=1.2.6
  removed jdk 9 and 10
  removed misterious GatlingSpec
  fixed build.sbt
  Updated with template-control on 2018-11-16T14:25:15.563Z   **build.sbt:     scalaVersion := "2.12.6"   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Upgrade branch 2.6.x using TemplateControl (playframework#54)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  Upgrade branch 2.6.x using TemplateControl (playframework#50)
  Upgrade branch 2.6.x using TemplateControl (playframework#49)
  Correct scalaVersion setting
  Revert gatling version changes
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-streaming-example/2.6.x' into…
9f32627 
… 2.6.x

* play-java-streaming-example/2.6.x: (45 commits)
  Nest play-java-streaming-example
  Updated with template-control on 2019-02-13T20:25:39.687Z (playframework#81)
  Upgrade branch 2.6.x using TemplateControl (playframework#79)
  Upgrade branch 2.6.x using TemplateControl (playframework#78)
  Upgrade branch 2.6.x using TemplateControl (playframework#77)
  Updated with template-control on 2019-01-08T14:44:41.668Z (playframework#75)
  Updated with template-control on 2019-01-04T17:13:23.629Z (playframework#70)
  Upgrade branch 2.6.x using TemplateControl (playframework#69)
  Upgrade branch 2.6.x using TemplateControl (playframework#66)
  Updated with template-control on 2018-09-11T20:14:50.512Z (playframework#65)
  Updated with template-control on 2018-08-20T20:37:13.644Z (playframework#64)
  Updated with template-control on 2018-07-19T01:58:55.832Z (playframework#62)
  Updated with template-control on 2018-07-16T18:38:45.449Z (playframework#61)
  Upgrade branch 2.6.x using TemplateControl (playframework#60)
  Updated with template-control on 2018-05-27T23:54:09.459Z (playframework#59)
  Updated with template-control on 2018-04-06T19:34:58.233Z (playframework#57)
  Updated with template-control on 2018-03-02T18:56:28.174Z (playframework#56)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Fix cross build to sbt 1.1.0 (playframework#54)
  Upgrade branch 2.6.x using TemplateControl (playframework#53)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-chatroom-example/2.6.x' into…
e6bfc46 
… 2.6.x

* play-scala-chatroom-example/2.6.x: (52 commits)
  Nest play-scala-chatroom-example
  Updated with template-control on 2019-02-13T20:25:39.259Z (playframework#76)
  Upgrade branch 2.6.x using TemplateControl (playframework#74)
  Upgrade branch 2.6.x using TemplateControl (playframework#73)
  Upgrade branch 2.6.x using TemplateControl (playframework#72)
  Updated with template-control on 2019-01-08T14:44:41.803Z (playframework#70)
  Updated with template-control on 2019-01-04T17:13:23.812Z (playframework#65)
  Upgrade branch 2.6.x using TemplateControl (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Updated with template-control on 2018-09-11T20:14:50.057Z (playframework#60)
  Updated with template-control on 2018-08-20T20:37:13.669Z (playframework#59)
  Updated with template-control on 2018-07-19T01:58:55.835Z (playframework#57)
  Updated with template-control on 2018-07-16T18:38:45.034Z (playframework#56)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2018-05-27T23:54:09.446Z (playframework#53)
  Updated with template-control on 2018-04-06T19:34:57.975Z (playframework#51)
  Updated with template-control on 2018-03-02T18:56:28.165Z (playframework#50)
  Upgrade branch 2.6.x using TemplateControl (playframework#49)
  Fix cross build to sbt 1.1.0 (playframework#48)
  Upgrade branch 2.6.x using TemplateControl (playframework#47)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-compile-di-example/2.6.x' in…
8903bb9 
…to 2.6.x

* play-scala-compile-di-example/2.6.x: (66 commits)
  Nest play-scala-compile-di-example
  Updated with template-control on 2019-02-13T20:25:39.413Z (playframework#87)
  Updated with template-control on 2019-02-01T10:40:33.389Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:58.005Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.884Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:42.104Z (playframework#81)
  Updated with template-control on 2019-01-04T17:13:23.804Z (playframework#76)
  Drop oraclejdk10
  Updated with template-control on 2018-11-29T15:50:43.529Z   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.7"
  Made minor changes to the README file documentation
  Updated with template-control on 2018-10-08T19:11:41.162Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.815Z (playframework#69)
  Updated with template-control on 2018-08-20T20:37:13.694Z (playframework#68)
  Updated with template-control on 2018-07-19T01:58:55.403Z (playframework#66)
  Updated with template-control on 2018-07-16T18:38:45.033Z (playframework#65)
  Upgrade branch 2.6.x using TemplateControl (playframework#64)
  Updated with template-control on 2018-05-27T23:54:09.150Z (playframework#63)
  Updated with template-control on 2018-04-06T19:34:58.408Z (playframework#61)
  Updated with template-control on 2018-03-02T18:56:27.945Z (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-isolated-slick-example/2.6.x…
5905ae3 
…' into 2.6.x

* play-scala-isolated-slick-example/2.6.x: (53 commits)
  Nest play-scala-isolated-slick-example
  Updated with template-control on 2019-02-13T20:25:39.661Z (playframework#84)
  Updated with template-control on 2019-02-01T10:40:33.042Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:58.033Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.882Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-08T14:44:41.929Z (playframework#78)
  Upgrade branch 2.6.x using TemplateControl (playframework#73)
  Remove JDK 9 & 10
  Updated with template-control on 2018-11-29T15:50:43.213Z   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.7"
  Updated with template-control on 2018-10-08T19:11:41.295Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")
  Updated with template-control on 2018-09-11T20:14:50.342Z (playframework#68)
  Updated with template-control on 2018-08-20T19:30:29.032Z (playframework#67)
  Updated with template-control on 2018-07-19T01:58:56.035Z (playframework#65)
  Updated with template-control on 2018-07-16T18:38:45.677Z (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#63)
  Updated with template-control on 2018-05-27T23:54:09.691Z (playframework#62)
  Updated with template-control on 2018-04-06T19:34:57.999Z (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#58)
  Fix cross build to sbt 1.1.0 (playframework#55)
  Update Play to version 2.6.10 (playframework#52)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-macwire-di-example/2.6.x' in…
47be391 
…to 2.6.x

* play-scala-macwire-di-example/2.6.x: (65 commits)
  Nest play-scala-macwire-di-example
  Updated with template-control on 2019-02-13T20:25:39.672Z (playframework#82)
  Updated with template-control on 2019-02-01T10:40:33.270Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:57.898Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:46.033Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:44.697Z (playframework#76)
  Updated with template-control on 2019-01-04T17:13:23.938Z (playframework#71)
  Upgrade branch 2.6.x using TemplateControl (playframework#70)
  Updated with template-control on 2018-10-08T19:11:40.533Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.619Z (playframework#66)
  Updated with template-control on 2018-08-20T20:37:13.853Z (playframework#65)
  Updated with template-control on 2018-07-19T01:58:55.845Z (playframework#63)
  Updated with template-control on 2018-07-16T18:38:45.430Z (playframework#62)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Updated with template-control on 2018-05-27T23:54:10.362Z (playframework#60)
  Updated with template-control on 2018-04-06T19:34:59.235Z (playframework#58)
  Updated with template-control on 2018-03-02T18:56:30.403Z (playframework#57)
  Upgrade branch 2.6.x using TemplateControl (playframework#56)
  Fix cross build to sbt 1.1.0 (playframework#55)
  Upgrade branch 2.6.x using TemplateControl (playframework#54)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-secure-session-example/2.6.x…
fff317a 
…' into 2.6.x

* play-scala-secure-session-example/2.6.x: (70 commits)
  Nest play-scala-secure-session-example
  Updated with template-control on 2019-02-13T20:17:46.435Z (playframework#95)
  Updated with template-control on 2019-02-01T10:40:32.758Z (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#92)
  Upgrade branch 2.6.x using TemplateControl (playframework#91)
  Upgrade branch 2.6.x using TemplateControl (playframework#89)
  Upgrade branch 2.6.x using TemplateControl (playframework#82)
  Upgrade branch 2.6.x using TemplateControl (playframework#81)
  adds mergify file (playframework#79)
  Upgrade branch 2.6.x using TemplateControl (playframework#77)
  Updated with template-control on 2018-08-20T20:37:13.861Z (playframework#71)
  Updated with template-control on 2018-07-19T01:58:55.998Z (playframework#69)
  Updated with template-control on 2018-07-16T18:38:45.458Z (playframework#68)
  Upgrade branch 2.6.x using TemplateControl (playframework#66)
  Updated with template-control on 2018-05-27T23:54:09.617Z (playframework#65)
  Updated with template-control on 2018-04-06T19:34:58.475Z (playframework#63)
  Updated with template-control on 2018-03-02T18:56:28.210Z (playframework#62)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Fix cross build to sbt 1.1.0 (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-slick-example/2.6.x' into 2.6.x
0a2f46a 
* play-scala-slick-example/2.6.x: (55 commits)
  Nest play-scala-slick-example
  Updated with template-control on 2019-02-13T20:25:39.652Z (playframework#92)
  Upgrade branch 2.6.x using TemplateControl (playframework#90)
  Updated with template-control on 2019-01-17T15:10:58.253Z (playframework#89)
  Upgrade branch 2.6.x using TemplateControl (playframework#88)
  Updated with template-control on 2019-01-08T14:44:41.666Z (playframework#85)
  Updated with template-control on 2019-01-04T17:13:23.925Z (playframework#79)
  Upgrade branch 2.6.x using TemplateControl (playframework#78)
  Upgrade branch 2.6.x using TemplateControl (playframework#75)
  Updated with template-control on 2018-09-11T20:14:50.417Z (playframework#74)
  Updated with template-control on 2018-08-20T20:37:13.878Z (playframework#73)
  Updated with template-control on 2018-07-19T01:58:55.997Z (playframework#71)
  Updated with template-control on 2018-07-16T18:38:45.495Z (playframework#70)
  Upgrade branch 2.6.x using TemplateControl (playframework#68)
  Updated with template-control on 2018-05-27T23:54:09.171Z (playframework#67)
  Updated with template-control on 2018-04-06T19:34:57.974Z (playframework#65)
  Updated with template-control on 2018-03-02T18:56:28.233Z (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#63)
  Fix cross build to sbt 1.1.0 (playframework#62)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dwijnand @octonato @ignasi35