Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New folder structure #558

Open
ihostage opened this issue Mar 1, 2024 · 5 comments
Open

New folder structure #558

ihostage opened this issue Mar 1, 2024 · 5 comments

Comments

@ihostage
Copy link
Member

ihostage commented Mar 1, 2024

I propose the next folder structure:

├─ java
│  ├─ chatroom
│  ├─ compile-di
│  ├─ dagger2
│  ├─ ebean
│  ├─ fileupload
│  ├─ forms
│  ├─ grpc
│  ├─ hello-world
│  ├─ jpa
│  ├─ pekko-cluster
│  ├─ rest-api
│  ├─ starter
│  ├─ streaming
│  └─ websocket
└─ scala
   ├─ anorm
   ├─ chatroom
   ├─ compile-di
   ├─ fileupload
   ├─ forms
   ├─ grpc
   ├─ hello-world
   ├─ isolated-slick
   ├─ log4j2
   ├─ macwire-di
   ├─ rest-api
   ├─ secure-session
   ├─ slick
   ├─ starter
   ├─ streaming
   ├─ tls
   └─ websocket
@ihostage
Copy link
Member Author

ihostage commented Mar 1, 2024

@mkurz WDYT?

@mkurz
Copy link
Member

mkurz commented Mar 1, 2024

@mkurz WDYT?

We can do that. This samples repo was put together from single github repos (each samples lived in its own repo...).
However, is there a bigger plan why you want to do that? Is it "just" to better organize things or do you have something else in mind?

@mkurz
Copy link
Member

mkurz commented Mar 1, 2024

Also if we do that we should not forget to update everything in https://github.com/playframework/play-samples/tree/main/.github (like scala-steward buildRoots, etc.)

@ihostage
Copy link
Member Author

ihostage commented Mar 4, 2024

We can do that. This samples repo was put together from single github repos (each samples lived in its own repo...). However, is there a bigger plan why you want to do that? Is it "just" to better organize things or do you have something else in mind?

The main reason to me is to better organize and simplify maintaining, you are right. Current folder names have a duplicate context information that it's an example and it's a Play example. But I know it, because It's a play-samples repo, that why I want to drop play- prefix and -example postfix in folder names and group by language. Yes, this removing can drop this context for users, who download examples and java/dagger2 and other folders already look not related with Play. But this case I propose to solve by other approach (#569)

My goal, that this repo should be used only maintainers and no one else. The common user should download an archive and just play with it 😄

@mkurz
Copy link
Member

mkurz commented Mar 4, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants