Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected exception for play-java-websocket example #20

Open
kelly-xuxixi opened this issue May 31, 2019 · 6 comments
Open

Unexpected exception for play-java-websocket example #20

kelly-xuxixi opened this issue May 31, 2019 · 6 comments
Labels
help wanted Extra attention is needed type:defect Something isn't working

Comments

@kelly-xuxixi
Copy link

Hi,

I encountered this problem when trying to render localhost:9000
image

I'm using java version "12.0.1" and sbt 1.2.8

Thanks!
dwijnand added a commit that referenced this issue Jun 3, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-log4j2-example/2.6.x' into 2…
3adb946 
….6.x

* play-scala-log4j2-example/2.6.x: (36 commits)
  Nest play-scala-log4j2-example
  Updated with template-control on 2019-02-13T20:25:39.787Z (#39)
  Upgrade branch 2.6.x using TemplateControl (#37)
  Updated with template-control on 2019-01-17T15:10:57.918Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.730Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:41.516Z (#33)
  Updated with template-control on 2019-01-04T17:13:24.081Z (#28)
  Remove JDK 9 & 10
  Updated with template-control on 2018-11-29T15:50:43.150Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2018-10-08T19:11:41.210Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.549Z (#23)
  set log4j2.xml as javaOptions (#20)
  Updated with template-control on 2018-08-20T20:37:13.971Z (#22)
  Updated with template-control on 2018-07-19T01:58:55.708Z (#19)
  Updated with template-control on 2018-07-16T18:38:45.739Z (#18)
  Upgrade branch 2.6.x using TemplateControl (#17)
  Updated with template-control on 2018-05-27T23:54:08.860Z (#16)
  Updated with template-control on 2018-04-06T19:34:58.294Z (#14)
  Updated with template-control on 2018-03-02T18:56:28.624Z (#13)
  Upgrade branch 2.6.x using TemplateControl (#12)
  ...
@dwijnand
Copy link
Member

dwijnand commented Jun 3, 2019

Hey @kelly-xuxixi. This is playframework/play-scala-websocket-example#93 and the workaround is installing Node.JS (e.g. version 10).

@octonato
Copy link
Member

octonato commented Jun 3, 2019

Can this be closed then?

@dwijnand
Copy link
Member

dwijnand commented Jun 3, 2019

No, it's an unresolved issue.

@kelly-xuxixi
Copy link
Author

@dwijnand Thanks. The problem is fixed after installing node.js

@marcospereira
Copy link
Member

Yeah, I think the correct fix is to:

  1. Drop Trireme support in js-engine and release a new version that only supports node (since Trireme does not support a modern version of node) with a clear error message if node command is not found.
  2. Update sbt-js-engine to use this release of js-engine.
  3. Update sbt-web plugins that depend on sbt-js-engine to use the new release of sbt-js-engine.
  4. Update our samples to use the version of such plugins.

Well, at least this maps the work that needs to be done to fix this for good. For now, the workaround is to install node.

@marcospereira marcospereira added help wanted Extra attention is needed type:defect Something isn't working labels Jun 4, 2019
@cgled
Copy link

cgled commented Dec 7, 2019

I just encountered this issue as well (commit 2183783)

If the aim of this example is to help non-experts understand how to do something interesting with webSockets, perhaps it would make sense to reduce the complexity of the example using vanilla js rather than coffeescript?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed type:defect Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@marcospereira @dwijnand @octonato @cgled @kelly-xuxixi