New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception noted when using bloom renderpass #6113
Comments
Could you please look in the debugger to see when this happens? Render actions are created for rendering of layers, so typically this cannot be null. Is there maybe an instance of RenderPassForward with no layers added to it? |
Do post effects still work in the new world or does this need porting to render passes? |
Post-effects work if you do not use render passes. |
Thats probably the issue then would it be unreasonable to log an error to the console in this case? |
Yeah that's definitely on the list. For now it's just a work in progress that's not released for public use. When we'll get it release-ready and documented, we'll port multiple engine examples to use it, make sure issues / errors are reported and similar. I'll see if I can add some assets for case early though. |
Thanks for your help, this is is why I wanted to test things to see what breaks ;). I'll give it another go again next release or two |
Description
I'm seeing an exception after testing the lastest builds when using the new renderpasses. Looking at the code in vscode makes it quite clear that it can be undefined so looks like a simple oversight
exception here
playcanvas.mjs:32653 Uncaught TypeError: Cannot read properties of null (reading 'id')
at ForwardRenderer.buildFrameGraph (playcanvas.mjs:32653:1)
at AppBase.renderComposition (playcanvas.mjs:42356:1)
at AppBase.render (playcanvas.mjs:42352:1)
at eval (playcanvas.mjs:42761:1)
I don't have an example repo case but hopefully the ide warning is enough
The text was updated successfully, but these errors were encountered: