Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use English names for Finnish regions #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kylmakalle
Copy link

See the issue for details: fixes plausible/analytics#3260
Parser will now use English names for Finnish regions instead of Swedish names. @ukutaht

JSON has been updated with mix update_english_translations command


P.S. During the contribution, I faced some ssl-dependency errors. I'm not so familiar with the elixir/erlang stack, so please make respective changes to mix.lock/mix.exc if needed, mix deps.update hackney command helped me. Ref: elixir-lang/elixir#12681 (comment)

@ukutaht
Copy link
Contributor

ukutaht commented Apr 1, 2024

Thank you @Kylmakalle this is great! The Finnish names look much better.

I used the JSON diff tool (https://jsondiff.com/) to check the changes to the translation file. Lots of things have changed because we just haven't run the scraper recently. On the positive side we now have English translations for regions of France, Portugal, China, Indonesia, Russia and many other countries. Also, existing translations for some countries seem to have improved (for example, Danish).

But there are some countries where we seem to have lost English translations that we had before. Need to check this list manually:

  1. Belarus replaced with local cryllic names (https://en.wikipedia.org/wiki/ISO_3166-2:BY)
  2. Armenia (https://en.wikipedia.org/wiki/ISO_3166-2:AM)
  3. Ethiopia (https://en.wikipedia.org/wiki/ISO_3166-2:ET)
  4. North Korea (https://en.wikipedia.org/wiki/ISO_3166-2:KP)
  5. Luxembourg (https://en.wikipedia.org/wiki/ISO_3166-2:LU)

This isn't related to your code changes but the underlying structure of the Wikipedia pages have changed such that the scraper is now failing to find the English names.

Again, not a problem with this PR but we need to address the list above before we can make the next release of this library. I'm not sure about merging this for now since it would put the main branch into kind of a dirty state that needs to be cleaned up. I think it's better to fix the issues above on top of this branch.

We can move this along but there's other stuff in the pipeline for at least 1 month before we can really put some work into this library. But thank you, this is a great start! ❤️

@Kylmakalle
Copy link
Author

@ukutaht thanks for the heads up. Let's keep it simple, I've reverted the JSON and this PR now only targets Finnish region names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region names are in Swedish language for Finland
2 participants