Shared link filtering and "Details" menus break the URL, removing the "/share" string

[pviprey]

Prerequisites

• I have searched open and closed issues to make sure that the bug has not yet been reported.

Bug report

This bug happens when using a private shared link. When clicking on 'DETAILS' on any windows for more details it updates the URL but removes the '/share' from it which will result in an infinite loop on the differents datas when you refresh the website/reopen the page after closing it earlier. Going back to the original page is also not enough as I still need to refresh it no matter what to get the datas.

Expected behavior
Load the datas whenever the site is resfresh or reopen later.

Environment (If applicable):

• OS: Pop_OS
• Browser: firefox
• Version 88.0.1

[ukutaht]

Thanks for reporting! We'll take a look

[bz2]

Same issue if applying any filters, the client-side history updating isn't preserving /share and that breaks the link.

[bz2]

The pathname of the <Link/> components are wrong:

analytics/assets/js/dashboard/stats/more-link.js

Line 9 in c95d375

to={`/${encodeURIComponent(site.domain)}/${endpoint}${window.location.search}`}

analytics/assets/js/dashboard/filters.js

Line 93 in 6e997e7

to={{ pathname: `/${encodeURIComponent(site.domain)}/filter/${filterGroupForFilter(key)}`, search: window.location.search }}

Either need a bit passed in to represent share/not-share and include that, or have another abstraction that can correctly generate a base path.

[ukutaht]

All correct. Thanks @bz2

[cwaring]

Confirmed that I am also experiencing this issue.

Steps to recreate:

1. Open a private shared link url
2. Apply a filter using the custom ui overlay
3. The /share/ path is removed from the url, thus breaking the url if it is copied and pasted to a new anonymous session

Notes:

• Filters applied by clicking the links in pages list do not break the share url
• If you add the /share/ path back into the url the functionality is restored