Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master branch isn't correctly being recognised #21

Open
erfanimani opened this issue Aug 31, 2017 · 0 comments
Open

Master branch isn't correctly being recognised #21

erfanimani opened this issue Aug 31, 2017 · 0 comments

Comments

@erfanimani
Copy link

https://github.com/platformsh/platformsh-magento2-configuration/blob/master/Platformsh.php#L471

It’s checking whether PLATFORM_ENVIRONMENT is equal to master.

However, running echo $PLATFORM_ENVIRONMENT returns master-{some_platform_id}.

Also, according to the docs, PLATFORM_BRANCH should be used instead; https://docs.platform.sh/development/variables.html#platformsh-environment-variables

As far as I can see, isMasterBranch will always return false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erfanimani