Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/etc/env.php autocreated when compile option is run #19

Open
waynetheisinger opened this issue Sep 9, 2016 · 1 comment
Open

app/etc/env.php autocreated when compile option is run #19

waynetheisinger opened this issue Sep 9, 2016 · 1 comment

Comments

@waynetheisinger
Copy link

waynetheisinger commented Sep 9, 2016

Platformsh.php decides whether to install Magento or update Config settings based on the existence of app/etc/env.php - but in Magento 2.1.1 (the only version I've tested) this file will always exist at the point at which the test runs because Magento has already created it when the compile command was run.

177c10f seems to be the commit that introduced this problem - I think a simple check whether the env exists at this stage might be enough to fix it

@waynetheisinger
Copy link
Author

Actually I'm not sure that a check on env.php is a good idea - env.php is particular to install so locally it will be different than on Platform so really it should be in .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant