platform self:install doesn't properly detect shell

[hanoii]

I think the issue is that the platform doesn't get the SHELL env var properly or populate within the child process or the like:

I am inside a ddev container:

$ echo $SHELL
/bin/bash

$ platform self:install
...
Setting up autocompletion... skipped (unsupported shell)
...

$ SHELL=$SHELL platform self:install -vvv
...
DEBUG Detected shell type: bash
Setting up autocompletion...# Running subcommand: _completion --generate-hook=1 --program=platform --shell-type=bash
 done
...

[pjcdawkins]

Hm, @akalipetis I thought we were sending the entire environment to the child process like this -

cli/internal/legacy/legacy.go

Line 159 in 5f1fdf6

cmd.Env = append(cmd.Env, os.Environ()...)

[akalipetis]

Yes, we do. That's quite strange and needs a bit of debugging, maybe the way os.Environ() works is not the one we believe? 😕

[hanoii]

This is not an issue on platform cli, see ddev/ddev#6018.