Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include flags from environment variables set externally #812

Open
jakirkham opened this issue Apr 17, 2024 · 1 comment
Open

Include flags from environment variables set externally #812

jakirkham opened this issue Apr 17, 2024 · 1 comment

Comments

@jakirkham
Copy link

In build systems (like conda-forge), some flags like CXXFLAGS are set as part of the build process to provide consistency across package builds and point to standard locations that may be part of the build system

IIUC it looks like scalene sets its own CXXFLAGS and doesn't pick up these values from the environment

CXXFLAGS = -std=c++14 -Wall -g -O3 -DNDEBUG -D_REENTRANT=1 -DHL_USE_XXREALLOC=1 -pipe -fno-builtin-malloc -fvisibility=hidden -Wno-unused-result

CXXFLAGS = /Ox /DNDEBUG /std:c++14 /Zi

Would it be possible for scalene to inherit environment variables set outside make and prepend/append to them?

@emeryberger
Copy link
Member

Would this solve the Python 3.8 build problem? If so - and if it doesn't interfere with regular builds with PyPi - we'd welcome a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants