Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4 library doesn't work with !pragma layout smetana #45

Closed
abhineet09 opened this issue Aug 26, 2021 · 5 comments
Closed

C4 library doesn't work with !pragma layout smetana #45

abhineet09 opened this issue Aug 26, 2021 · 5 comments

Comments

@abhineet09
Copy link

abhineet09 commented Aug 26, 2021

Diagrams generated using C4-plantuml library, doesn't render relationships when !pragma layout smetana is used

Sample notation:

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Component.puml
!pragma layout smetana
System_Boundary(a, "a"){

    Container_Boundary(b, "b"){

          Component(c, "c", "xyz", "c")

   }
}

Person(d, "d")
Person(e, "e")

Rel(a, d, "a to d")
Rel(a, e, "a to e")
Rel(b, c, "b to c")
@enduml

Without Smetana layout:

raw

With Smetana Layout:

Capture

@kirchsth
Copy link
Contributor

Hi @abhineet09,

I'm not sure if smetana is maintained at all, maybe you test it with the elk layout.

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Component.puml
!pragma layout elk
System_Boundary(a, "a"){

Container_Boundary(b, "b"){

      Component(c, "c", "xyz", "c")

}
}

Person(d, "d")
Person(e, "e")

Rel(a, d, "a to d")
Rel(a, e, "a to e")
Rel(b, c, "b to c")
@enduml

BR Helmut

@huornlmj
Copy link

Elk is an alpha feature, and results in this error with no diagram:
image

@kirchsth
Copy link
Contributor

Do you have the problem with a local plantuml.jar file?
Does it work on the PlantUML server?

If it is a local problem:
Do you have elk-full.jar in the same folder as the plantuml.jar?
If not please add it and try it again (details see Usage)

If it doesn't work on server too:
Can you add a sample.

BR Helmut

@kirchsth
Copy link
Contributor

Hi all,

I checked it again, and smetana looks fixed in the meantime

BR Helmut

@The-Lum
Copy link
Collaborator

The-Lum commented May 23, 2024

Hi all,

[This is an Issue Review] 👀
This is now answered.

  • Thanks @abhineet09 for the report.
  • Thanks @kirchsth for your answer.
  • Thanks PlantUML team for your work.

Regards.

@The-Lum The-Lum closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants