Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration screen is displayed for new users #1206

Open
boreq opened this issue Feb 28, 2023 · 2 comments
Open

Migration screen is displayed for new users #1206

boreq opened this issue Feb 28, 2023 · 2 comments
Assignees
Labels
2.0 bug Something isn't working ui Issues that are primarily improving the user interface in a particular area
Milestone

Comments

@boreq
Copy link
Contributor

boreq commented Feb 28, 2023

Right now the migration screen shows up even for new users when they complete onboarding. This is just confusing (why is this thing migrating if I just installed it?) and effectively adds another screen to onboarding. The idea would be to dismiss the screen automatically if the migrations take longer then for example 10 seconds to run.

@boreq boreq added ui Issues that are primarily improving the user interface in a particular area 2.0 labels Feb 28, 2023
@boreq boreq added this to the Scuttlego milestone Feb 28, 2023
@mplorentz
Copy link
Member

The title says the idea is to dismiss it if it's quick, but the description says

dismiss the screen automatically if the migrations take longer then for example 10 seconds to run
which sounds like the opposite to me?

It sounds like a bug that we show the migration screen or run migrations on a fresh install. Would it be a better fix to just not run this migration if there is no go-ssb data? Or we could detect that we are onboarding in Swift, assume the migration will be near-instant as there is nothing to migrate, and skip showing the screens.

@boreq
Copy link
Contributor Author

boreq commented Mar 3, 2023

I mean we can try not triggering the handlers if migrations determine that there is nothing to do but they have to be run to check if there is nothing to do. This will add a small complication to every migration but it is doable.

@boreq boreq changed the title Idea: dismiss migration screen automatically if it is quick Migration screen is displayed for new users Mar 3, 2023
@boreq boreq added the bug Something isn't working label Mar 3, 2023
@boreq boreq self-assigned this Mar 3, 2023
@boreq boreq modified the milestones: Release 2.0.0, Release 2.0.1 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 bug Something isn't working ui Issues that are primarily improving the user interface in a particular area
Projects
None yet
Development

No branches or pull requests

2 participants