Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnects slow down replication #1204

Open
boreq opened this issue Feb 27, 2023 · 2 comments
Open

Disconnects slow down replication #1204

boreq opened this issue Feb 27, 2023 · 2 comments
Assignees
Labels
bug Something isn't working go-bindings Things that relate to Go bindings in any way. go-scuttlego Things that relate to scuttlego in any way. replication issue All work related to replication of posts on Planetary

Comments

@boreq
Copy link
Contributor

boreq commented Feb 27, 2023

Problem:

  • during replication the pubs disconnect often
  • this is perhaps related to their internal connection management logic and not a problem with scuttlego or planetary
  • this is especially problematic during initial replication
  • the connection is not reestablished until swift calls ssbDisconnectAll and ssbConnectPeer again

Proposed solution:

  • replace ssbDisconnectAll and ssbConnectPeer with a function which sets a list peers that we should stay connected to and lets scuttlego reestablish connections e.g. ssbStayConnectedTo
  • this is a dynamic alternative to already existing configuration field "preferred pubs"
@boreq boreq added bug Something isn't working replication issue All work related to replication of posts on Planetary 2.0 go-scuttlego Things that relate to scuttlego in any way. go-bindings Things that relate to Go bindings in any way. labels Feb 27, 2023
@boreq boreq added this to the Scuttlego milestone Feb 27, 2023
@boreq boreq self-assigned this Feb 28, 2023
@boreq
Copy link
Contributor Author

boreq commented Mar 1, 2023

I am going to wait with doing anything here as I don't know how much of a problem this is. It is just something I noticed during testing. Definitely not something that should stop us from deploying to test flight. Also this is something that would have been a problem before scuttlego as well.

@boreq
Copy link
Contributor Author

boreq commented Mar 3, 2023

Related to #301.

@boreq boreq removed this from the Release 2.0.0 milestone Mar 7, 2023
@boreq boreq removed the 2.0 label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go-bindings Things that relate to Go bindings in any way. go-scuttlego Things that relate to scuttlego in any way. replication issue All work related to replication of posts on Planetary
Projects
Archived in project
Development

No branches or pull requests

1 participant