Feature/prevent stage pause #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| foreach (var info in _action.skillInfos) | ||
| { | ||
| var target = info.Target; | ||
| if (target == null || target.IsDead) |
There was a problem hiding this comment.
기존에는 타겟 죽은경우 타겟의 연출을 기다리고 진행되는부분이 바로넘어가는부분으로 바뀐건가요?
There was a problem hiding this comment.
기존 로직 기준으로 죽은 캐릭터가 자기 자신을 타겟으로 한 연출을 수행하는 경우 무한대기에 빠지는 상황이여서 로직을 수정하다 죽은 대상의 연출을 기다리는게 맞는건가 싶어서 이렇게 로직을 수정했었습니다.
There was a problem hiding this comment.
죽은 대상의 연출을 기다리는것이 의도적인것이였다면 해당 로직은 수정하도록 하겠습니다
jonny-jeahyunchoi
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Links
#4908