Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not update expText view when there is no expText object #4798

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

eugene-doobu
Copy link
Member

Description

레시피 뷰에 expText 오브젝트가 없으면 갱신시도 안하도록 변경하였습니다.

How to test

레시피에서 EventEquipmentDesc 아이템 확인시 텍스트 관련 에러가 없는지 확인합니다

Related Links

#4797

@eugene-doobu eugene-doobu requested a review from a team as a code owner April 22, 2024 09:46
@eugene-doobu eugene-doobu changed the base branch from development to prepare/170.0.x April 22, 2024 09:46
Copy link
Member

@sonohoshi sonohoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

룬 스프라이트 추가되는건 의도된 사항인가요?

@eugene-doobu eugene-doobu merged commit 0d5c4d7 into prepare/170.0.x Apr 23, 2024
16 checks passed
@eugene-doobu eugene-doobu deleted the issue/4797 branch April 23, 2024 02:37
@eugene-doobu
Copy link
Member Author

@sonohoshi 아.. 까먹고 답변을 안달고 머지했는데 깃허브 상태동기화 에러로 보이고 실제로는 스프라이트가 추가되지 않았습니다. 머지 타겟 바꾸면 가끔 이런 이슈 발생하더라구요... 확인은 머지커밋에서 해보실 수 있습니다
0d5c4d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

레시피 뷰에 expText없으면 갱신시도 안하도록 변경
3 participants