You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the proposal
There are some implementations in the codebase that use the Pimple for the purpose of dependency injection. This package is a part of micro framework Silex which as been deprecated quite some times ago. Also as we have laravel's own dependency injection container, it's better to use that as we are adopting more from laravel's toolset .
What application are you using?
OJS, OMP or OPS version main (3.5.0 pre release)
Additional information
Only few classes are using it such as
PKP\core\PKPServices
APP\core\Services
APP\services\OJSServiceProvider
APP\services\OMPServiceProvider
APP\services\OPSServiceProvider
Probably a good approach is to utilize the app or shared lib(pkp-lib) specific AppServiceProvider to put the functionalities there .
The text was updated successfully, but these errors were encountered:
Describe the proposal
There are some implementations in the codebase that use the Pimple for the purpose of dependency injection. This package is a part of micro framework Silex which as been deprecated quite some times ago. Also as we have laravel's own dependency injection container, it's better to use that as we are adopting more from laravel's toolset .
What application are you using?
OJS, OMP or OPS version main (3.5.0 pre release)
Additional information
Only few classes are using it such as
Probably a good approach is to utilize the app or shared lib(pkp-lib) specific
AppServiceProvider
to put the functionalities there .The text was updated successfully, but these errors were encountered: