Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pimple with laravel's dependency injection container #9913

Open
touhidurabir opened this issue Apr 25, 2024 · 1 comment
Open

Replace pimple with laravel's dependency injection container #9913

touhidurabir opened this issue Apr 25, 2024 · 1 comment
Assignees
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.

Comments

@touhidurabir
Copy link
Member

Describe the proposal
There are some implementations in the codebase that use the Pimple for the purpose of dependency injection. This package is a part of micro framework Silex which as been deprecated quite some times ago. Also as we have laravel's own dependency injection container, it's better to use that as we are adopting more from laravel's toolset .

What application are you using?
OJS, OMP or OPS version main (3.5.0 pre release)

Additional information
Only few classes are using it such as

  1. PKP\core\PKPServices
  2. APP\core\Services
  3. APP\services\OJSServiceProvider
  4. APP\services\OMPServiceProvider
  5. APP\services\OPSServiceProvider

Probably a good approach is to utilize the app or shared lib(pkp-lib) specific AppServiceProvider to put the functionalities there .

@touhidurabir touhidurabir added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Apr 25, 2024
@jonasraoni
Copy link
Contributor

I think this can be closed as a duplicate of #7131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Development

No branches or pull requests

3 participants