Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Playable #1301

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Refactor Playable #1301

wants to merge 3 commits into from

Conversation

Dr-Blank
Copy link
Contributor

this is a draft only, find discussion here

Description

  • transfer attributes to playable class which are required by the methods it provides
  • make it an abstract class
  • playable is its own file to avoid circular import of media in to base

Fixes #1290

Checklist for affected classes

  • Track
  • Photo
  • Playlist
  • Movie
  • Episode
  • Clip

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

- transfer .media to playable class
- playble is its own file to avoid circular import of `media` in to `base`
@JonnyWong16
Copy link
Collaborator

Playable should be further broken down in to AudioPlayable and VideoPlayable.

The lyric/subtitle methods are currently in Audio and Video but they only apply to Track and Movie/Episode.

Ref: #1303, #1305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Improvement: Fix class Playable
2 participants