Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv2_vertex and uv2_pars_vertex failing mtoon VRM rendering in Three v151 #1198

Closed
antpb opened this issue Mar 31, 2023 · 3 comments · Fixed by #1218
Closed

uv2_vertex and uv2_pars_vertex failing mtoon VRM rendering in Three v151 #1198

antpb opened this issue Mar 31, 2023 · 3 comments · Fixed by #1218
Assignees
Labels
bug Something isn't working
Milestone

Comments

@antpb
Copy link

antpb commented Mar 31, 2023

In Three.js v151 there were changes that removed uv2_vertex and uv2_pars_vertex which cause issues loading VRM files that have the mtoon shader.

Here is the Three.js change: mrdoob/three.js@5c5a5c7#diff-c2bc4656a48180f106fc5f8813c5d6fd1fe51f8af74b7ac5e1939661379d4841

I found that mtoon uses uv2_vertex and uv2_pars_vertex in Line 42 and 17 of the mtoon.vert file.

I attempted to comment them out, but as expected it broke things further. Reporting here as I try to solve the problem. :)

@antpb antpb changed the title uv2_vertex and uv2_pars_vertex failing mtoon VRM rendering uv2_vertex and uv2_pars_vertex failing mtoon VRM rendering in Three v151 Mar 31, 2023
@0b5vr 0b5vr added the bug Something isn't working label Apr 6, 2023
@0b5vr
Copy link
Contributor

0b5vr commented Apr 6, 2023

oh no. I will fix this in the next version.

Thank you for the report.

@0b5vr 0b5vr added this to the next(v1.0.10) milestone Apr 6, 2023
@0b5vr 0b5vr self-assigned this Apr 6, 2023
0b5vr added a commit that referenced this issue Apr 20, 2023
This does not work yet, there are compatibility breaks around shaders

See: #1198
@0b5vr
Copy link
Contributor

0b5vr commented May 8, 2023

r151 support is way harder than I thought; there are many breaking changes on shaderchunks.
Expect more time to support r151.

See:

@0b5vr 0b5vr pinned this issue May 9, 2023
0b5vr added a commit that referenced this issue May 9, 2023
This does not work yet, there are compatibility breaks around shaders

See: #1198
@0b5vr
Copy link
Contributor

0b5vr commented May 31, 2023

@antpb v1.0.10 should fix the shader compilation problem, please try the new version!

https://github.com/pixiv/three-vrm/releases/tag/v1.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants