-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 SinglepartWriter writes on exception when garbage collected #819
Comments
3 tasks
hi @donsokolone 👋 how about setting cc @mpenkov |
donsokolone
added a commit
to donsokolone/smart_open
that referenced
this issue
Apr 20, 2024
donsokolone
added a commit
to donsokolone/smart_open
that referenced
this issue
Apr 20, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem description
When there is an unhandled exception raised in context of SinglepartWriter side-effect occurs when writer is garbage-collected which results in unwanted write of partial file into S3.
Reason for this behaviour is
SinglepartWriter
inheritsio.BufferedIOBase
which invokesclose()
in__del__()
descriptior.Steps/code to reproduce the problem
smart_open
logger level to DEBUGsmart_open.s3.SinglepartWriter
log records indicating S3 write was performedVersions
The text was updated successfully, but these errors were encountered: