Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused values in DistanceJoint's serializer #136

Open
zOadT opened this issue Jul 20, 2020 · 0 comments
Open

Unused values in DistanceJoint's serializer #136

zOadT opened this issue Jul 20, 2020 · 0 comments

Comments

@zOadT
Copy link
Collaborator

zOadT commented Jul 20, 2020

The serializer of DistanceJoint saves the values of m_impulse, m_gamma and m_bias. This has no affect in the deserialize method, because their value is hard coded to zero in the constructor. This can be easily fixed by overriding the values manually after creating the joint.

To me it seems like at least m_impulse can keep a positive value afer calling initVelocityConstraints amd therefore can also have an effect on the computations, but I am not completely sure. If it would make a different we would also have to update the other joints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant