Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi logging WIP #52

Closed
wants to merge 1 commit into from
Closed

Multi logging WIP #52

wants to merge 1 commit into from

Conversation

bbugh
Copy link

@bbugh bbugh commented Jun 4, 2021

Note: The multi_test.rb in the root folder is there to do quick tests if you want to use it.

Describe the change

Adds logging to ProgressBar::Multi.

Why are we doing this?

There have been many times where I've wanted a multi progress bar that also outputs text - tests, async scripts, ETL, etc.

Benefits

You can use it in more places where you need logging and progress.

Drawbacks

Not sure of any drawbacks.

Requirements

None of these yet, but will if it works

  • Tests written & passing locally?
  • Code style checked?
    • Rubocop seems to be out of date - many unrelated formatting issues
  • Rebased with master branch?
  • Documentation updated?
  • Changelog updated?

Closes #51

@bbugh bbugh mentioned this pull request Jun 4, 2021
Repository owner deleted a comment from houndci-bot Jun 5, 2021
Repository owner deleted a comment from houndci-bot Jun 5, 2021
Repository owner deleted a comment from houndci-bot Jun 5, 2021
Repository owner deleted a comment from houndci-bot Jun 5, 2021
Repository owner deleted a comment from houndci-bot Jun 5, 2021
Repository owner deleted a comment from houndci-bot Jun 5, 2021
Repository owner deleted a comment from houndci-bot Jun 5, 2021
Repository owner deleted a comment from houndci-bot Jun 5, 2021
@piotrmurach
Copy link
Owner

Hi Brian,

I'll close this one since it's been open for a long time, and no one chimed in with implementation. I also believe that the solution will need to take into account the move_to_row for each progress bar rendered. This is not a trivial task and I won't have time to implement this given my list of other open source projects waiting to be written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding MultiBar logging
2 participants