Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new deployment statuses #370

Open
3clypse opened this issue Dec 11, 2020 · 1 comment
Open

Support new deployment statuses #370

3clypse opened this issue Dec 11, 2020 · 1 comment

Comments

@3clypse
Copy link

3clypse commented Dec 11, 2020

馃憢 First of all, thanks for the project.

Issue

I saw that the gem doesn't support the deployment statuses: in_progress or queued.

The reason is because instead of sending 'application/vnd.github.cannonball-preview+json', they require application/vnd.github.flash-preview+json in the Accept header for these statuses while are in beta.

Tests

I checked that using application/vnd.github.flash-preview+json in all deployments requests made (list N deployments, get a status from a deployment, ...) worked like a charm. I assume that's the only change it needs.

Docs

@piotrmurach
Copy link
Owner

Hi David,

Thanks for submitting the issue report.

You can either provide accept header value with your request or submit PR to get this changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants