Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTPS for webpage #303

Open
evidenz opened this issue Oct 20, 2021 · 7 comments
Open

Enable HTTPS for webpage #303

evidenz opened this issue Oct 20, 2021 · 7 comments

Comments

@evidenz
Copy link

evidenz commented Oct 20, 2021

Is there a way I can enable HTTPS for the service exposed?

@winkidney
Copy link
Member

winkidney commented Oct 21, 2021

We haven't built HTTPS support into the docker.
You could just use tools like Caddy to create an https reverse proxy (with automic let's encrypt certificate access).

ref: https://caddyserver.com/docs/quick-starts/reverse-proxy

Hope it helps.

@825i
Copy link

825i commented Feb 23, 2022

Can I ask why you haven't? HTTPS has been the default transfer protocol for the last 10 years now...

@winkidney
Copy link
Member

Can I ask why you haven't? HTTPS has been the default transfer protocol for the last 10 years now...

If you only host one site on a single server, we could provide HTTPS support by default.
In case of hosting multiple sites on a single server, you'd better config HTTPS by yourself, it's my concern about this.

@825i
Copy link

825i commented Feb 24, 2022

I think 99% of people just want to host their own. Even baking letsencrypt in would be a good idea. 

@winkidney
Copy link
Member

I think 99% of people just want to host their own. Even baking letsencrypt in would be a good idea.

PR is very welcome : )

@lapo-luchini
Copy link
Contributor

Fastest would probably to use Caddy instead of nginx inside the Docker itself. 🤔

Unfortunately I'm not very interested in Docker itself or else I'd try this. 😇

@jgwehr
Copy link

jgwehr commented Apr 3, 2023

As others have said, HTTPS is much better handled by the tools meant to auto-negotiate/renew the certificates rather than individual containers. I don't think any of my containers have their own https.

Fortunately, I use Caddy and have examples! I was able to get Pinry behind a reverse proxy and on HTTPS within seconds.

Caddy file: https://github.com/jgwehr/homelab-docker/blob/3768a58bd79d98e3345dff3fc0068f9c44fde444/staticconfig/caddy/Caddyfile#L150
Docker Compose: https://github.com/jgwehr/homelab-docker/blob/3768a58bd79d98e3345dff3fc0068f9c44fde444/docker-compose.yml#L573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants