[Feature]if viewing a board and then creating a pin, automatically select that board in the new pins board list.

[MWP]

Hi all,

So just added a pin to a private board, but im finding that the pin is still visible when not logged in (its not private).
If pins on a board don't adapt the privacy option of the board, what is the point of having the board privacy option?

Thanks.

[winkidney]

Hi,
In Pinry, you could pin a image to your board from other's Pin board, your Pin is just a "symbol-link" of OriginalPin so you will never have access to change its status (privacy option for example).

If you want to hide both the Pin and the board, you should set the board as private and Pins in the board as private (But you could never affect the Pin which you don't owned).

Even in this case, privacy option for board also has its sense: you could hide your own collection as you wish.

This is the point currently, If you have any better idea, please send a PR or we could have more discussion.

[MWP]

I see.
Maybe a small change could be made: If you're adding a new pin and select a board that is private, the pin's private checkbox also becomes ticked.

[winkidney]

I see.
Maybe a small change could be made: If you're adding a new pin and select a board that is private, the pin's private checkbox also becomes ticked.

It make sense and thanks for your advice.
I will finish this change once I have time, PR is very welcome : )

[MWP]

That would be great, thankyou.

And a couple more suggestions if you don't mind:
1 - allow source URLs over 256 chars long
2 - if viewing a board and then creating a pin, automatically select that board in the new pins board list.

Thanks again.

[winkidney]

That would be great, thankyou.

And a couple more suggestions if you don't mind:
1 - allow source URLs over 256 chars long
2 - if viewing a board and then creating a pin, automatically select that board in the new pins board list.

Thanks again.

The second one is nice to have while I'm not sure about the first one.

Some strange URL has too many unexpected arguments (for exampel useless query string but we don't know whether it is useless), We have no silver bullets for this and I don't want the URL grows day by day.

Do you have any better idea?

[MWP]

Well, I was trying to pin some facebook image URLs a few days ago which didn't work due to the URLs being over 256 bytes.
I tried trimming the URLs down, but it seems Facebook uses the URL to enforce image timelimits, and other things. Changing/removing any of the args invalidated the image.
Hence my request.
The industry standard for max URL length appears to be 2048 chars.

[winkidney]

Length change has been done, you could update your source code right now or docker image later after the automatic building done.

Another one will be done once I have time.

[MWP]

Amazing, thank you!

[MWP]

Length change has been done, you could update your source code right now or docker image later after the automatic building done.

I just updated my docker image, and it appears the 256 character limit is still in place?

[winkidney]

Sorry, migrations should be done by hand.
Please have a try and tell me what happened, thanks.

docker exec -it <your-docker-container-id> bash
# then
python manage.py migrate --noinput --settings=pinry.settings.docker

[MWP]

root@wheeee:~# docker exec -it pinry bash
root@c3742dc8910f:/pinry# python manage.py migrate --noinput --settings=pinry.settings.docker
Operations to perform:
Apply all migrations: admin, auth, contenttypes, core, django_images, sessions, taggit, users
Running migrations:
Applying core.0010_auto_20210311_1521... OK
root@c3742dc8910f:/pinry# exit

I then stopped and restarted the container.
The 256 char limit is still in place.

To make sure the migration did work, I tried your instructions again and it reported "No migrations to apply.".

[winkidney]

Thanks for your feedback, the url length limit also exists in frontend.
I've changed it now.
ref: 659ad35

Please wait for latest docker-build or build it by yourself then restart your container, it will work.

Please contact me if you have any problem.

[MWP]

Perfect! Confirmed it works at longer lengths.
Thankyou.