-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookmarklet should allow uploading file #66
Comments
I'm reworking the bookmarklet entirely. CSP is causing issues with just allowing the bookmarklet to run. I'm working on a new solution that bypasses this by grabbing the image and uploading it from the user's browser instead of pulling an image from the server. |
Any news on that approach? |
No progress on this feature currently. I'm working on the new UI built by vue.js with Bluma(like bootstrap). |
I like Vue.JS a lot too (so maybe I can help on the client-side of Pinry in the future, even if I don't know any Python), but I'd like to keep the bookmarklet as lean as possible, and using only VanillaJS as far as possible. But that doesn't make it easy to upload a local URL… or maybe yes, the image is probably cached (and thus, avoid origial website Refer checks) even when called from a different tab (the bookmarklet opens a new one). |
@lapo-luchini Keep bookmarket alone make sense! |
Basically the image we find on a website should be uploaded via the bookmarklet directly to pinry and not pulled via the pinry server, it would solve a lot of issues... |
Now the API level works well with image upload. |
(enhancement request)
Some websites check images for Referrer and/or origin IP.
It would be nice to add to the bookmarklet landing page a checkbox to upload local image instead of delegating the download to the server (and maybe even doing that automatically when the server-side download fails).
The text was updated successfully, but these errors were encountered: