txn: handle errors returned from Flush #52890
Conversation
ti-chi-bot
bot
added
release-note-none
size/M
|
Hi @ekexium. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ekexium
force-pushed
the
handle-asseriton-error-for-flush
branch
from
4413164
to
156d97a
Compare
pkg/session/session.go
Outdated
| @@ -2274,6 +2270,14 @@ func runStmt(ctx context.Context, se *session, s sqlexec.Statement) (rs sqlexec. | |||
| } | |||
|
|
|||
| rs, err = s.Exec(ctx) | |||
|
|
|||
| // Pipelined-DML can return assertion error and write conflict here, handle them like we handle | |||
There was a problem hiding this comment.
We have a new fork here(Commit and Flush). It may increase maintainability if we can avoid such duplicated code. But I have no good idea right now.
ekexium
changed the title
ekexium
force-pushed
the
handle-asseriton-error-for-flush
branch
from
156d97a
to
ec382e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52890 +/- ##
=================================================
- Coverage 72.3651% 55.2824% -17.0828%
=================================================
Files 1482 1594 +112
Lines 428430 598065 +169635
=================================================
+ Hits 310034 330625 +20591
- Misses 99104 244366 +145262
- Partials 19292 23074 +3782
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…eturned from Commit Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
handle-asseriton-error-for-flush
branch
from
ec382e1
to
fd4328a
Compare
Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
|
/retest |
|
@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: ekexium <eke@fastmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, crazycs520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: ekexium <eke@fastmail.com>
…n-error-for-flush
|
/retest |
|
@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52889
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.