Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb section2, test case false positive #334

Open
schneiderlin opened this issue Apr 9, 2020 · 0 comments · May be fixed by #335
Open

tidb section2, test case false positive #334

schneiderlin opened this issue Apr 9, 2020 · 0 comments · May be fixed by #335
Labels
type/bug Something isn't working

Comments

@schneiderlin
Copy link

I encounter a test failure like this

➜  mapreduce git:(master) ✗ make test_homework 
go test -v -run=TestURLTop
=== RUN   TestURLTop
Case0 PASS, dataSize=1MB, nMapFiles=5, cost=46.062897ms
    TestURLTop: urltop10_test.go:89: Case1 FAIL, dataSize=1MB, nMapFiles=5, cost=20.123106ms
        expected:
        github.com/pingcap/tidb/issues/0: 5204
        github.com/pingcap/tidb/issues/3: 5189
        github.com/pingcap/tidb/issues/4: 5189
        github.com/pingcap/tidb/pull/2: 5181
        github.com/pingcap/tidb/issues/5: 5144
        github.com/pingcap/tidb/6: 5130
        github.com/pingcap/tidb/1: 5118
        
        , but got:
        github.com/pingcap/tidb/issues/0: 5204
        github.com/pingcap/tidb/issues/4: 5189
        github.com/pingcap/tidb/issues/3: 5189
        github.com/pingcap/tidb/pull/2: 5181
        github.com/pingcap/tidb/issues/5: 5144
        github.com/pingcap/tidb/6: 5130
        github.com/pingcap/tidb/1: 5118
        
        
        
--- FAIL: TestURLTop (0.08s)
FAIL
exit status 1
FAIL    talent  0.081s
Makefile:9: recipe for target 'test_homework' failed
make: *** [test_homework] Error 1

i think order of the url shouldn't matter, given they have the same frequency(5189 in this case),these two output are equivalent and test should pass.
@schneiderlin schneiderlin added the type/bug Something isn't working label Apr 9, 2020
@schneiderlin schneiderlin linked a pull request Apr 9, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tidb/mapreduce: relaxing utils/CheckFile
1 participant
@schneiderlin