Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failpoints.Disable not remove failpath from fps.reg #80

Open
gerayking opened this issue Sep 8, 2023 · 1 comment
Open

Failpoints.Disable not remove failpath from fps.reg #80

gerayking opened this issue Sep 8, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gerayking
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
    I'm trying to iterate over failpoint.List() to obtain all the enabled failpoint keys. However, I'm also retrieving deprecated keys from the list.
  2. What did you expect to see?
    After calling failpoint.disable(key), the key should no longer be present in fps.reg
  3. What did you see instead?
    Now, even after I disable a failpoint key, I can still retrieve it once it has been enabled.4. Versions of the failpoint
    • failpoint-ctl version (run failpoint-ctl -V):

      (paste failpoint-ctl version here)
      ReleaseVersion None
      BuildTS None
      GitHash None
      GitBranch None
      GoVersion None
      
@gerayking gerayking added the bug Something isn't working label Sep 8, 2023
@gerayking
Copy link
Author

I managed to address the issue by using failpoint.status(fppath). However, I'm unclear about the status of the failpoints returned by failpoint.List(). Does it show failpoints that are defined, enabled, or disabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant