Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: pimcore:bundle:install should no-op if a bundle is already installed #17029

Open
evanjamesjackson opened this issue May 8, 2024 · 0 comments · May be fixed by #17030
Open

[Improvement]: pimcore:bundle:install should no-op if a bundle is already installed #17029

evanjamesjackson opened this issue May 8, 2024 · 0 comments · May be fixed by #17030

Comments

@evanjamesjackson
Copy link
Contributor

evanjamesjackson commented May 8, 2024

Improvement description

Currently, when running bin/console pimcore:bundle:install with a bundle that is already installed, an error is generated: [ERROR] Bundle BundleName can not be installed. This is a problem in Docker-based and continuous integration/deployment scenarios, as we regularly run (and re-run) such commands as part of the init operations of our applications. In order to workaround this issue, we have to use the --fail-without-error flag (which may ignore legitimate problems with the bundle installation), or choose to ignore errors altogether in the init script (e.g. by not setting set -e in the entrypoint of a container, which is not ideal as this will cause the script to skip other legitimate errors)

In my view, trying to install a bundle that is already installed is not an error situation, and the default behaviour of this command should be to no-op and continue without error. Alternatively, if the behaviour of the current command is desirable, I suggest adding an optional flag to the command to ignore bundles that are already installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant