Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: srcset is added multiple times to images in wysiwyg #17028

Open
gfemorris opened this issue May 8, 2024 · 0 comments
Open

[Bug]: srcset is added multiple times to images in wysiwyg #17028

gfemorris opened this issue May 8, 2024 · 0 comments
Labels

Comments

@gfemorris
Copy link

gfemorris commented May 8, 2024

Pimcore version

11.2.2

Steps to reproduce

Drop a big image into the wysiwyg so that a width is automatically applied. Without the width it does not occur.
We tested this with a localized field. I am not sure if it happens in a non-localized field as well.
srcset needs to be added to the allowed attributes of the img tag element in allow_elements in config.yaml

Actual Behavior

During the saving of the object Text::wysiwygText is called multiple times. Each time $additionalAttributes are added without replacing or checking if they are already existent. So you end up with an image tag with multiple srcsets.

Expected Behavior

srcset should be added only once into the image tag.

@gfemorris gfemorris added the Bug label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant