[Improvement] Add Gotenberg support to define screenshot size #17023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
kingjia90
commented
May 8, 2024
| @@ -6,6 +6,8 @@ | |||
| - Unused setting `general.language` has been deprecated. | |||
| #### [Listing] | |||
| - The methods `setOrder()` and `setOrderKey()` throw an `InvalidArgumentException` if the parameters are invalid now. | |||
| #### [Html to Image] | |||
| - [Gotenberg] Bumped the lowest requirement of `gotenberg-php` from `^2.0` to `^2.4` to add support of passing screenshot size | |||
There was a problem hiding this comment.
does this phrasing sounds clear that the minimum ^1.1 is still supported?
There was a problem hiding this comment.
Agree that it's potentially a little bit strange, but I would say it's fine. Some kind of convoluted sentence which describes the reason for the ^1.1 support wouldn't make it better, so let's write it like this.
markus-moser
approved these changes
May 16, 2024
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #17009