Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gotenberg previews: consider window size of screenshots #17009

Closed
brusch opened this issue May 2, 2024 · 0 comments · Fixed by #17023
Closed

Gotenberg previews: consider window size of screenshots #17009

brusch opened this issue May 2, 2024 · 0 comments · Fixed by #17023
Assignees
@kingjia90
Labels
Improvement
Milestone
11.3.0

Comments

@brusch
Copy link
Member

brusch commented May 2, 2024

Improvement description

Follow up to #16608

Currently the window size it getting ignored here:

pimcore/lib/Image/HtmlToImage.php

Line 128 in 18cf215

$urlResponse = $request->screenshot()

because Gotenberg didn't had the functionality.

But now it's implemented:
gotenberg/gotenberg#816 (comment)

So we should consider the config and pass it to Gotenberg accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingjia90 kingjia90

Labels
Improvement
Projects
None yet
Milestone
11.3.0
Development

Successfully merging a pull request may close this issue.

[Improvement] Add Gotenberg support to define screenshot size pimcore/pimcore
2 participants
@brusch @kingjia90