New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: invalid-option message pop up in every product object. #16991
Comments
but then you would have no chance of knowing, that in DB there is actually a invalid value, right? |
@fashxp It doesn't matter from my perspective if I entered the wrong value just displays the empty value in the select option. I can review data-import logs to see if I entered the incorrect value for this attribute. Still, an invalid pop message is annoying for my client especially since we have many select options attributes. Hence, in case I entered 3-4 wrong values I get 4 different invalid option messages so when the client displays the object he should click for time on the message above not a good practice. I think it will be better if the invalid-option message has more info so I can detect which attribute causes the problem. |
with having a better error message I fully agree! But we should not ignore that case completely. |
@fashxp can i extend the built-in class in data-importer and in case i didn't find the value in the select input, i can just set it as empty. |
Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding. |
Pimcore version
11
Steps to reproduce
migrate some products using any api and entering invalid options for select options input
Actual Behavior
migrate some products using any api and entering invalid options for select options input
I want to show an empty option in case the value that has been sent from the API is not valid instead of showing this annoying message
this error happened because I sent a value 2 to this attribute
what I expect in case I sent the wrong value to show an empty option without displaying this message.
Expected Behavior
when I import the wrong value in the select-option attribute this message don't pop up and instead shows an empty option
The text was updated successfully, but these errors were encountered: