Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented / incorrect error handling #21

Open
Richie765 opened this issue Jan 23, 2018 · 0 comments
Open

Undocumented / incorrect error handling #21

Richie765 opened this issue Jan 23, 2018 · 0 comments

Comments

@Richie765
Copy link
Contributor

The historical function returns an empty array [] on any kind of error (network error, symbol not found, etc). While investigating I found there is an undocumented option error that can be set to true to get errors thrown.

I believe it is better to remove this option and just throw the errors so the user of the module can handle the errors the way they like.

Same applies to companyNews and yahoo-finance.historical.

If you agree I can make a PR request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant