Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setWithdrawalQueue #39

Open
1 of 5 tasks
MickdeGraaf opened this issue Jun 3, 2021 · 0 comments
Open
1 of 5 tasks

Implement setWithdrawalQueue #39

MickdeGraaf opened this issue Jun 3, 2021 · 0 comments

Comments

@MickdeGraaf
Copy link
Member

User Story

  • As an <audience/user>: PieAdmin
  • I want to <action/task>: Set the withdrawal queue
  • so that <outcome/goal/benefit>: So the least profitable or less expensive ones to exit are withdrawn from first when a user withdraws.

Type

  • Enhancement
  • Maintenance
  • Refactor

Description

When a user does a large withdraw, the PieVault will often have to withdraw from strategies. The order in which this happens is determined by the withdrawal queue. Each underlying asset has its own withdrawalQueue.

Definition of Done

  • Implement setWithdrawalQueue
  • Unit test setWithdrawalQueue

Part of #30
See LibStrategyBasketStorage.sol on yearn-strategy-support for the storage structure
See the Yearn implementation as reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MickdeGraaf