Update to Dart sass to allow @use at-rule use #669

mlbiche · 2021-02-24T17:57:50Z

@use

- Update project to Dart Sass - Replace @import rules with @use

hound · 2021-02-24T17:58:03Z

src/_chips.scss

 // Chips
 .chip {
  align-items: center;
-  background: $bg-color-dark;
+  background: variables.$bg-color-dark;


Invalid CSS after "...ound: variables": expected ";", was ".$bg-color-dark;"

hound · 2021-02-24T17:58:03Z

src/_hero.scss

@@ -17,6 +19,6 @@
  }

  .hero-body {
-    padding: $layout-spacing;
+    padding: variables.$layout-spacing;


Invalid CSS after "...ding: variables": expected ";", was ".$layout-spacing;"

hound · 2021-02-24T17:58:03Z

src/_buttons.scss

-  border: $border-width solid $primary-color;
-  border-radius: $border-radius;
-  color: $primary-color;
+  background: variables.$bg-color-light;


Invalid CSS after "...ound: variables": expected ";", was ".$bg-color-light;"

hound · 2021-02-24T17:58:03Z

src/_comparison-sliders.scss

@@ -30,7 +32,7 @@
    z-index: 1;

    .comparison-label {
-      right: $unit-4;
+      right: variables.$unit-4;


Invalid CSS after "...ight: variables": expected ";", was ".$unit-4;"

hound · 2021-02-24T17:58:04Z

src/_empty.scss

-  background: $bg-color;
-  border-radius: $border-radius;
-  color: $gray-color-dark;
+  background: variables.$bg-color;


Invalid CSS after "...ound: variables": expected ";", was ".$bg-color;"

hound · 2021-02-24T17:58:05Z

src/_dropdowns.scss

@@ -29,8 +31,8 @@
  // Fix dropdown-toggle border radius in button groups
  .btn-group {
    .dropdown-toggle:nth-last-child(2) {
-      border-bottom-right-radius: $border-radius;
-      border-top-right-radius: $border-radius;
+      border-bottom-right-radius: variables.$border-radius;


Invalid CSS after "...dius: variables": expected ";", was ".$border-radius;"

hound · 2021-02-24T17:58:05Z

docs/src/scss/docs.scss


 .version::after {
-  content: "#{$version}";
+  content: "#{variables.$version}";


Invalid CSS after "...t: "#{variables": expected "}", was ".$version}";"

hound · 2021-02-24T17:58:06Z

gulpfile.js

@@ -1,6 +1,6 @@
 const gulp = require("gulp");
 const { parallel } = require("gulp");
-const sass = require('gulp-sass');
+const sass = require('gulp-dart-sass');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2021-02-24T17:58:06Z

src/_accordions.scss

@@ -15,15 +17,15 @@

  .accordion-header {
    display: block;
-    padding: $unit-1 $unit-2;
+    padding: variables.$unit-1 variables.$unit-2;


Invalid CSS after "...ding: variables": expected ";", was ".$unit-1 variab..."

hound · 2021-02-24T17:58:06Z

src/_asian.scss

 // Optimized for East Asian CJK
 html:lang(zh),
 html:lang(zh-Hans),
 .lang-zh,
 .lang-zh-hans {
-  font-family: $cjk-zh-hans-font-family;
+  font-family: variables.$cjk-zh-hans-font-family;


Invalid CSS after "...mily: variables": expected ";", was ".$cjk-zh-hans-f..."

hound · 2021-02-24T18:03:30Z

src/_popovers.scss

@@ -6,13 +9,13 @@
  .popover-container {
    left: 50%;
    opacity: 0;
-    padding: $layout-spacing;
+    padding: variables.$layout-spacing;


Invalid CSS after "...ding: variables": expected ";", was ".$layout-spacing;"

hound · 2021-02-24T18:03:30Z

src/_parallax.scss

@@ -12,7 +15,7 @@ $parallax-fade-color: rgba(255, 255, 255, .35) !default;
  outline: none;
  position: absolute;
  width: 50%;
-  z-index: $zindex-1;
+  z-index: variables.$zindex-1;


Invalid CSS after "...ndex: variables": expected ";", was ".$zindex-1;"

hound · 2021-02-24T18:03:30Z

src/_panels.scss

 // Panels
 .panel {
-  border: $border-width solid $border-color;
-  border-radius: $border-radius;
+  border: variables.$border-width solid variables.$border-color;


Invalid CSS after "...rder: variables": expected ";", was ".$border-width ..."

hound · 2021-02-24T18:03:30Z

src/_modals.scss

@@ -7,7 +10,7 @@
  left: 0;
  opacity: 0;
  overflow: hidden;
-  padding: $layout-spacing;
+  padding: variables.$layout-spacing;


Invalid CSS after "...ding: variables": expected ";", was ".$layout-spacing;"

hound · 2021-02-24T18:03:30Z

src/_labels.scss

 // Labels
 .label {
-  @include label-base();
-  @include label-variant(lighten($body-font-color, 5%), $bg-color-dark);
+  @include mixins.label-base();


Invalid CSS after " @include mixins": expected "}", was ".label-base();"

hound · 2021-02-24T18:03:32Z

src/_navbar.scss

@@ -22,7 +24,7 @@
  }

  .navbar-brand {
-    font-size: $font-size-lg;
+    font-size: variables.$font-size-lg;


Invalid CSS after "...size: variables": expected ";", was ".$font-size-lg;"

hound · 2021-02-24T18:03:32Z

src/_avatars.scss

 // Avatars
 .avatar {
-  @include avatar-base();
-  background: $primary-color;
+  @include mixins.avatar-base();


Invalid CSS after " @include mixins": expected "}", was ".avatar-base();"

hound · 2021-02-24T18:03:32Z

src/_media.scss

@@ -66,10 +68,10 @@ video.video-responsive {

 // Figure
 .figure {
-  margin: 0 0 $layout-spacing 0;
+  margin: 0 0 variables.$layout-spacing 0;


Invalid CSS after "...: 0 0 variables": expected ";", was ".$layout-spacin..."

hound · 2021-02-24T18:03:32Z

src/_steps.scss

 // Steps
 .step {
  display: flex;
  flex-wrap: nowrap;
  list-style: none;
-  margin: $unit-1 0;
+  margin: variables.$unit-1 0;


Invalid CSS after "...rgin: variables": expected ";", was ".$unit-1 0;"

hound · 2021-02-24T18:03:32Z

src/_tooltips.scss

 // Tooltips
 .tooltip {
  position: relative;
  &::after {
-    background: rgba($dark-color, .95);
-    border-radius: $border-radius;
+    background: rgba(variables.$dark-color, .95);


Invalid CSS after "... rgba(variables": expected ")", was ".$dark-color, ...."

…d utilities stylesheets

hound · 2021-02-26T17:36:49Z

src/_menus.scss

-  @include shadow-variant(.05rem);
-  background: $bg-color-light;
-  border-radius: $border-radius;
+  @include mixins.shadow-variant(.05rem);


Invalid CSS after " @include mixins": expected "}", was ".shadow-variant..."

hound · 2021-02-26T17:36:49Z

src/_meters.scss

 // Meters
 // Credit: https://css-tricks.com/html5-meter-element/
 .meter {
  appearance: none;
-  background: $bg-color;
+  background: variables.$bg-color;


Invalid CSS after "...ound: variables": expected ";", was ".$bg-color;"

hound · 2021-02-26T17:36:50Z

src/icons/_icons-action.scss

 // Icon resize
 .icon-resize-horiz,
 .icon-resize-vert {
  &::before,
  &::after {
-    border: $icon-border-width solid currentColor;
+    border: icons-core.$icon-border-width solid currentColor;


Invalid CSS after "...der: icons-core": expected ";", was ".$icon-border-w..."

hound · 2021-02-26T17:36:50Z

src/icons/_icons-core.scss

 // Icon variables
-$icon-border-width: $border-width-lg;
+$icon-border-width: variables.$border-width-lg;


Invalid CSS after "...idth: variables": expected selector or at-rule, was ".$border-width-lg;"

hound · 2021-02-26T17:36:50Z

src/icons/_icons-object.scss

 // Icon time
 .icon-time {
-  border: $icon-border-width solid currentColor;
+  border: icons-core.$icon-border-width solid currentColor;


Invalid CSS after "...der: icons-core": expected ";", was ".$icon-border-w..."

hound · 2021-02-26T17:36:51Z

src/spectre-exp.scss


-/*! Spectre.css Experimentals v#{$version} | MIT License | github.com/picturepan2/spectre */
+/*! Spectre.css Experimentals v#{variables.$version} | MIT License | github.com/picturepan2/spectre */


Invalid CSS after "...ls v#{variables": expected "}", was ".$version} | MI..."

hound · 2021-02-26T17:36:51Z

src/spectre.scss


-/*! Spectre.css v#{$version} | MIT License | github.com/picturepan2/spectre */
+/*! Spectre.css v#{variables.$version} | MIT License | github.com/picturepan2/spectre */


Invalid CSS after "...ss v#{variables": expected "}", was ".$version} | MI..."

hound · 2021-02-26T17:36:52Z

src/utilities/_colors.scss

 // Text colors
-@include text-color-variant(".text-primary", $primary-color);
+@include mixins.text-color-variant(".text-primary", variables.$primary-color);


Invalid CSS after "@include mixins": expected selector or at-rule, was ".text-color-var..."

hound · 2021-02-26T17:36:52Z

src/utilities/_divider.scss

 // Divider
 .divider,
 .divider-vert {
  display: block;
  position: relative;

  &[data-content]::after {
-    background: $bg-color-light;
-    color: $gray-color;
+    background: variables.$bg-color-light;


Invalid CSS after "...ound: variables": expected ";", was ".$bg-color-light;"

hound · 2021-02-26T17:36:52Z

src/utilities/_loading.scss

 // Loading
 .loading {
  color: transparent !important;
-  min-height: $unit-4;
+  min-height: variables.$unit-4;


Invalid CSS after "...ight: variables": expected ";", was ".$unit-4;"

Mlbiche added 3 commits February 23, 2021 08:46

Update project to Dart Sass

c2a2e36

- Update project to Dart Sass - Replace @import rules with @use

Update main mixins stylesheet to forward other mixins stylesheets

1dd1193

Update documentation and documentation stylesheets

99a1963

hound bot reviewed Feb 24, 2021

View reviewed changes

Fix missing trailing line

f10d87e

hound bot reviewed Feb 24, 2021

View reviewed changes

Update main icons and utilities stylesheets to forward other icons an…

443e5af

…d utilities stylesheets

hound bot reviewed Feb 26, 2021

View reviewed changes

mlbiche mentioned this pull request Jun 1, 2021

Dart Sass 2.0.0 #678

Open

davestewart mentioned this pull request Sep 20, 2023

Review PRs spectre-org/spectre-css#5

Open

30 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Dart sass to allow @use at-rule use #669

Update to Dart sass to allow @use at-rule use #669

mlbiche commented Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 24, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021

hound bot Feb 26, 2021


		/! Spectre.css Experimentals v#{$version} \| MIT License \| github.com/picturepan2/spectre /
		/! Spectre.css Experimentals v#{variables.$version} \| MIT License \| github.com/picturepan2/spectre /


		/! Spectre.css v#{$version} \| MIT License \| github.com/picturepan2/spectre /
		/! Spectre.css v#{variables.$version} \| MIT License \| github.com/picturepan2/spectre /

Update to Dart sass to allow @use at-rule use #669

Are you sure you want to change the base?

Update to Dart sass to allow @use at-rule use #669

Conversation

mlbiche commented Feb 24, 2021

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 24, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment

hound bot Feb 26, 2021

Choose a reason for hiding this comment