Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent width with role=group #484

Open
mwargan opened this issue Mar 7, 2024 · 1 comment
Open

Inconsistent width with role=group #484

mwargan opened this issue Mar 7, 2024 · 1 comment

Comments

@mwargan
Copy link

mwargan commented Mar 7, 2024

Describe the issue

It's inconsistent to have a button group be 100% width when the buttons individually are not so.

Current Behavior

Buttons grow to collectively fill 100% width.

Expected Behavior

Buttons use only size they need, much like individual buttons.

If we remove width: 100%; from the [role=group], [role=search] selectors, we can get rid of this problem. Its also inconsistent that this rule sets width: 100% but using inline-flex - if we want 100% width its usually a sign of a need for block-behaviour, in which case using inline flex over just flex wouldn't make sense.

@mwargan
Copy link
Author

mwargan commented Mar 7, 2024

Note that the above is a "pseudo-suggestion", it would need a bit more tweaks as it screws up the search and button group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant