node version restriction

[olehmisar]

[olehmisar]

Why does a css library that runs in browser and and doesn't even export any js restrict node version?

[olehmisar]

Not sure where the 20.11.1 version comes from, as version 18 is specified in the package.json

pico/package.json

Line 65 in 6dc6489

"node": ">=18.19.0"

Anyway, it prevents me from deploying on vercel.

[lucaslarroche]

One of the devDependencies, postcss-cli, requires node >=18.
What is the best practice?
Should we remove any node version requirement?

[olehmisar]

IDK about the best practice, but there is no need for "engines" field in package.json because your package does not run on node.js (it does not even run js at all).

However I am not sure if removing "engines" from package.json will fix the vercel deployment issue. Could you please publish a @next version or something like that, so I can test it before you publish a new patch version?

[lucaslarroche]

@olehmisar can you try with:

"@picocss/pico": "github:picocss/pico#remove-node-engines"

Thanks for testing

[olehmisar]

works nicely. No error on node 18

[gary600]

Same issue happens on latest release on Cloudflare Pages (as a warning rather than an error, but still annoying), so this change would be appreciated since the reason for including Pico is just for the stylesheets.