Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cards (<article> tags) have poor contrast with background in light mode #449

Open
gekoke opened this issue Feb 13, 2024 · 2 comments · May be fixed by #461
Open

Cards (<article> tags) have poor contrast with background in light mode #449

gekoke opened this issue Feb 13, 2024 · 2 comments · May be fixed by #461

Comments

@gekoke
Copy link

gekoke commented Feb 13, 2024 •
edited

Describe the issue

Cards have very poor contrast with the background when using Pico v2's light theme.

image

Cards are sufficiently visually distinct in the dark mode.

image

Current Behavior

Cards are nearly indistinguishable from the background when using the light mode.

Expected Behavior

Cards are easily distinguishable from the background when using the light mode, perhaps by employing a slightly thicker shadow.
@lucaslarroche
Copy link
Member

@gekoke, I prefer to keep the shadow light/subtle to keep Pico's style neutral.
Plus, it's customizable with CSS variables.

But yes, it lacks some contrast, maybe we could do this:
https://codepen.io/lucastests/pen/bGZZeBK

@lucaslarroche lucaslarroche linked a pull request Feb 18, 2024 that will close this issue
style: card shadow #461
Draft
@Brian-Pob
Copy link

I believe that the contrast issues might be display-based. The UI in the attached screenshots looks fine on my 2021 14" MacBook Pro with adequate contrast.

Looking at it on my Gigabyte G27Q 1440p monitor with default settings there is almost no visible contrast even with the shadows. However, when I change the color temperature to a different mode the contrast becomes visible.

I have attached some pictures of my monitor with the different settings enabled to try to make the issue more visible. Hopefully these help.

UI with standard monitor settings
UI with sRGB settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: card shadow picocss/pico
3 participants
@lucaslarroche @Brian-Pob @gekoke