Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility issues with the pihole web-ui #1174

Open
mhussaincov opened this issue Mar 3, 2020 · 9 comments
Open

accessibility issues with the pihole web-ui #1174

mhussaincov opened this issue Mar 3, 2020 · 9 comments
Labels

Comments

@mhussaincov
Copy link

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:
1
{Replace this with a number from 1 to 10. 1 being not familiar, and 10 being very familiar}


Expected behaviour:
I use a screen reader orca on debian linux, the parts of the web-ui that are not accessible are the folowing
Total queries over last 24 hours
after that is spoken by orca, the graphic part is not accessible,
all that orca the screen reader will tell me is canvus clickable.

nore is the part write after this bit.
Client activity over last 24 hours
the same is repeated.

{A detailed description of what you expect to see}
would it be possible to have a text version of the graphical parts of the webui in text format for people like me who don't have site?
simply a text version of the pieces of information that is reprozented by the graphics?
e.g the urls accessed etc?

Actual behaviour:
the parts stated above are not accessible to orca the screen reader.
{A detailed description and/or screenshots of what you do see}

Steps to reproduce:
1.
launch orca from your linux distribution of choise most distributions have it pre installed.
2.
go to your pihole admin interface and log in.
3.
navigate to
Client activity over last 24 hours
and down arrow once.
you will hear no useful information after that

this happens in the firefox browser and chromium, one

{Detailed steps of how we can reproduce this}

Debug token provided by uploading pihole -d log:

{Alphanumeric token}

Troubleshooting undertaken, and/or other relevant information:

I tryed chrome and firefox both with the same reaction.
{Steps of what you have done to fix this}

@PromoFaux PromoFaux transferred this issue from pi-hole/pi-hole Mar 3, 2020
@PromoFaux
Copy link
Member

Hi there,

Thanks for the report. I must say this is not something I had ever really thought about before, but it is certainly something that we can look into improving.

@mhussaincov
Copy link
Author

mhussaincov commented Mar 3, 2020 via email

@dschaper
Copy link
Member

dschaper commented Mar 3, 2020

Our accessibility is not where we'd like it to be. Colors and alternative displays need some work. I agree with Promo that we can look at this. Thank you for reporting it.

@mhussaincov
Copy link
Author

mhussaincov commented Mar 3, 2020 via email

@dschaper
Copy link
Member

dschaper commented Mar 3, 2020

You didn't offend me at all, I'm honestly thankful for your bringing this to our attention.

@PromoFaux
Copy link
Member

Not at all! It's a very valid criticism that we really should take on board, it just never occurred to me before that someone hard-of-sight would be using an ad blocker :)

Presumably adverts get in the way of/ are read out by screen readers?

@mhussaincov
Copy link
Author

mhussaincov commented Mar 3, 2020 via email

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@yubiuser
Copy link
Member

Adding Bug to this so that it's not going to be stale again. I think accessible issues should not auto-closed, but needs active closing by affected people after an issue is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants