Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to section "Blocking Https Advertisement Assets" that it is only needed for Pihole version < 4.0 #336

Open
kyondev opened this issue Jun 7, 2020 · 2 comments

Comments

@kyondev
Copy link

kyondev commented Jun 7, 2020

WARNING: I'm not 100% sure about this. So please excuse me if this issue was a mistake/is wrong.

As far as I have understood it, as of version 4.0 of Pi-hole there is no need to execute the iptables commands listet in the "Blocking Https Advertisement Assets" section here.
Reason as to why I think this is an issue: The edit "Update: 2018-08-06" in the top post

@dschaper
Copy link
Member

The default blocking method did change with version 4 to no longer use the Pi-hole IP address. However you can still use that method if you require the blocking page so the iptables directions do still apply. There's no risk of breakage if you do have those rules in your chains so I think everything is okay?

@kyondev
Copy link
Author

kyondev commented Aug 27, 2020

This is just a cosmetic issue. Did not want people unnecessarily having to run the commands when they do not provide any benefits for the new default blocking mode.
So this means the hint should be that this is only useful when using BLOCKINGMODE=IP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants