Suggestion about usage of checkAlwaysTrueStrictComparison

[grga-giscloud]

Hi, I've tried turning on this flag and it finds some things I wanted it to find. Something like

$x = $this->foo();
if ($x !== null) {
  (...)
}

And I know that foo doesn't return null and it reports that. And this is good. However, it also complains about example like:

enum Foo {
	case Bar;
	case Baz;
}

function foo (Foo $x) : void {
	match ($x) {
		Foo::Bar => 0,
		Foo::Baz => 1
	};
}

Same example written here: https://phpstan.org/r/4de19a7a-7f51-4319-b757-fe7f7a63cb82 but I couldn't force it to give error since I didn't figure out how to turn on that flag in Playground.
If I change the last Foo:Baz to default, that fixes it. But I don't want to change it to default since more cases might appear in enum and I want to catch it. Somewhat similar discussion here: #10556

Do you have any suggestions on how I should approach this?

[ondrejmirtes]

You're probably using an old PHPStan version, that's why it doesn't show up in the playground.

I agree that if you want to handle all enum cases, default is counterproductive. It's better to remove default and let PHPStan tell you you're missing a case: https://phpstan.org/r/8dc983c5-0f75-43fa-a051-c906e3f837fe

Also please note there are some changed if you enable Bleeding Edge:

1. "always true" comparisons are always reported for everyone, the options to enable it will be removed in PHPStan 2.0
2. Compare the behaviour in this example: https://phpstan.org/r/de4a9720-2429-4021-8a68-18e72deb125a vs https://phpstan.org/r/5c9256ad-f4ed-4ff5-9ede-d08dae65fedd

[grga-giscloud]

Ok thanks, if the option to enable this flag is going away looks like I want to turn the flag off

[ondrejmirtes]

But the new behaviour will be as if it was true.

The real takeaway is you should update to the latest version, and that you should use Bleeding Edge.

[grga-giscloud]

Oh yeah looks like I've misread you first time, apologies - I parsed "the options to enable it will be removed" incorrectly

Yeah looks like I want to update and then if I'll have some doubts I'll come back here. Thanks!