Deprecate methods deprecated in Redis and add their replacements to phpredis where they're missing or not accepting required arguments

[kkmuffme]

Redis deprecated various methods that should also be deprected in phpredis.
Data taken from https://redis.io/commands.json

• 1) BRPOPLPUSH https://github.com/phpredis/phpredis?tab=readme-ov-file#brpoplpush
  deprecated_since: 6.2.0
  replaced_by: BLMOVE with the RIGHT and LEFT arguments

=> BLMOVE does not have documentation yet for phpredis

• 2) CLIENT KILL/ arguments https://github.com/phpredis/phpredis?tab=readme-ov-file#client
  deprecated_since: 2.8.12

=> docs only to remove "old format" and document "new format" https://redis.io/commands/client-kill/

• 3) GEORADIUS https://github.com/phpredis/phpredis?tab=readme-ov-file#georadius
  deprecated_since: 6.2.0
  replaced_by: GEOSEARCH and GEOSEARCHSTORE with the BYRADIUS argument

=> the replacements aren't documented in phpredis yet

• 4) GEORADIUSBYMEMBER https://github.com/phpredis/phpredis?tab=readme-ov-file#georadiusbymember
  deprecated_since: 6.2.0
  replaced_by: GEOSEARCH and GEOSEARCHSTORE with the BYRADIUS and FROMMEMBER arguments

=> see 3)

• 5) GETSET https://github.com/phpredis/phpredis?tab=readme-ov-file#getset
  deprecated_since: 6.2.0
  replaced_by: SET with the !GET argument

=> the function should be deprecated and SET documented for this use case

• 6) HMSET https://github.com/phpredis/phpredis?tab=readme-ov-file#hmset
  deprecated_since: 4.0.0
  replaced_by: HSET with multiple field-value pairs

=> the function should be deprecated and HSET documented for this use case

• 7) https://github.com/phpredis/phpredis?tab=readme-ov-file#setex-psetex
  SETEX
  deprecated_since: 2.6.12
  replaced_by: SET with the EX argument
  and
  PSETEX
  deprecated_since: 2.6.12
  replaced_by: SET with the PX argument

=> function should be deprecated and documentation updated with an example for set/pset

• 8) RPOPLPUSH https://github.com/phpredis/phpredis?tab=readme-ov-file#rpoplpush
  deprecated_since: 6.2.0
  replaced_by: LMOVE with the RIGHT and LEFT arguments

=> LMOVE isn't documented in phpredis yet

• 9) SETNX https://github.com/phpredis/phpredis?tab=readme-ov-file#setnx
  deprecated_since: 2.6.12
  replaced_by: SET with the NX argument

=> deprecated method and remove from docs, the "nx" behavior is already sufficiently documented in the replacement https://github.com/phpredis/phpredis?tab=readme-ov-file#set

• 10) SLAVEOF https://github.com/phpredis/phpredis?tab=readme-ov-file#slaveof
  deprecated_since: 5.0.0
  replaced_by: REPLICAOF

=> the replacement isn't documented in phpredis yet

• 11) ZRANGEBYLEX https://github.com/phpredis/phpredis?tab=readme-ov-file#zrangebylex
  deprecated_since: 6.2.0
  replaced_by: ZRANGE with the BYLEX argument

=> the replacement https://github.com/phpredis/phpredis?tab=readme-ov-file#zrange doesn't currently support the arguments needed or are only the docs outdated?

• 12) https://github.com/phpredis/phpredis?tab=readme-ov-file#zrangebyscore-zrevrangebyscore
  ZRANGEBYSCORE
  deprecated_since: 6.2.0
  replaced_by: ZRANGE with the BYSCORE argument
  and
  ZREVRANGEBYSCORE
  deprecated_since: 6.2.0
  replaced_by: ZRANGE with the REV and BYSCORE arguments

=> see 11)

• 13) ZREVRANGE https://github.com/phpredis/phpredis?tab=readme-ov-file#zrevrange
  deprecated_since: 6.2.0
  replaced_by: ZRANGE with the REV argument

=> see 11)

[michael-grunder]

Thanks for the report.

I'm not sure how aggressive we should be in terms of the deprecations as many people are still using old versions of Redis. I wouldn't want to break people's code if we don't need to.

Also can you clarify the CLIENT KILL deprecation. I'm probably missing something obvious but it doesn't seem deprecated to me. 😄

[kkmuffme]

I'm not sure how aggressive we should be in terms of the deprecations as many people are still using old versions of Redis

As a first step, I would suggest to only update the docs with clear @deprecated tags for those functions and ensure their replacement is documented, to ensure people who do not use phpredis yet, won't use any of these deprecated functions.

Additionally the stubs phpdoc should get a @deprecated tag added, so static analysis tools will pick up on that, to allow for a gradual transition from deprecated functions.

Since Redis itself has only marked it deprecated but not actually deprecated, I think this is sufficient to ensure consistency between Redis and phpredis docs and awareness that these functions will eventually be deprecated.

Also can you clarify the CLIENT KILL deprecation. I'm probably missing something obvious but it doesn't seem deprecated to me.

Yeah sorry that description was a bit wonky. Fixed now:

=> docs only to remove "old format" and document "new format" https://redis.io/commands/client-kill/