Setting the integer values with serializer/compression, does not work with increments

[bmtKIA6]

Expected behaviour

Same output whether compression/serializer is enabled or disabled.
Running the code with the defaults, works.
With compression/serializer in any permutation, does not work.

<?php
error_reporting(E_ALL);

ini_set('display_errors', 1);
ini_set("output_buffering", "off");
ini_set("max_execution_time", -1);

header("Content-type: text/plain");

echo PHP_VERSION . PHP_EOL;


$redis = new Redis();
$redis->connect('redis', 6379);
//$redis->setOption(Redis::OPT_SERIALIZER, Redis::SERIALIZER_IGBINARY);
//$redis->setOption(Redis::OPT_COMPRESSION, Redis::COMPRESSION_LZ4);

assert($redis->ping());


$key = "int_key_42";

var_dump($redis->set($key, 42));
var_dump($redis->getLastError());
var_dump($redis->get($key));
var_dump($redis->getLastError());
var_dump($redis->incr($key, 42));
var_dump($redis->getLastError());
var_dump($redis->get($key));
var_dump($redis->getLastError());

output

7.4.33
bool(true)
NULL
string(2) "42"
NULL
int(84)
NULL
string(2) "84"
NULL

enable compression/serializer

<?php
error_reporting(E_ALL);

ini_set('display_errors', 1);
ini_set("output_buffering", "off");
ini_set("max_execution_time", -1);

header("Content-type: text/plain");

echo PHP_VERSION . PHP_EOL;


$redis = new Redis();
$redis->connect('redis', 6379);
$redis->setOption(Redis::OPT_SERIALIZER, Redis::SERIALIZER_IGBINARY);
$redis->setOption(Redis::OPT_COMPRESSION, Redis::COMPRESSION_LZ4);

assert($redis->ping());


$key = "int_key_42";

var_dump($redis->set($key, 42));
var_dump($redis->getLastError());
var_dump($redis->get($key));
var_dump($redis->getLastError());
var_dump($redis->incr($key, 42));
var_dump($redis->getLastError());
var_dump($redis->get($key));
var_dump($redis->getLastError());

output

7.4.33
bool(true)
NULL
int(42)
NULL
bool(false)
string(44) "ERR value is not an integer or out of range�"
int(42)
string(44) "ERR value is not an integer or out of range�"

Actual behaviour

I'm seeing this behaviour on

• OS: Ubuntu 22.04 and 20.04
• Redis: 7.0.11
• PHP: 8.1.2 / 7.4.33
• phpredis: 5.3.7

Steps to reproduce, backtrace or example script

I've checked

• There is no similar issue from other users
• Issue isn't fixed in develop branch

[bmtKIA6]

@yatsukhnenko is this an expected behavior?

Should we be creating wrappers and have checks with is_numeric and disabling the compression/serialization?

[michael-grunder]

Should we be creating wrappers and have checks with is_numeric and disabling the compression/serialization?**

You could do that or use a distinct object for serverside operations like INCR.

The reason it's not a bug is that INCR and DECR happen entirely on the server, and an igbinary serialized number won't look like a number to Redis, so it will just return an error.

There's not really anything we can do about that on our end.