Internal classes

[aivchen]

I have an idea.
We can mark all classes which should not used by users as @internal (https://docs.phpdoc.org/2.9/references/phpdoc/tags/internal.html) and make a new patch release.

After that, we will be able to change them as we want without fear of violating B/C.

What do you think?

But I'll need you help here as I don't know which classes must remain "public".

[dantleech]

tbh, all concrete classes can be @internal AFAIK so those can be final. in theory extension points should use interfaces, anything that can be tagged in the dependency injection container are a public API. e.g. ProgressLogger

e.g.

phpbench/lib/Extension/RunnerExtension.php

Lines 115 to 117 in 914cee8

	final public const TAG_ENV_PROVIDER = 'runner.environment_provider';
	final public const TAG_EXECUTOR = 'runner.benchmark_executor';
	final public const TAG_PROGRESS_LOGGER = 'runner.progress_logger';

the ProviderInterface is collected by the TAG_ENV_PROVIDER so it's an extension point and needs to be public.

[aivchen]

Ok, and all classes used in interfaces must be public I assume.
For example, Information is used in ProviderInterface so we keep Information public, right (but we can mark as internal all its methods except __constructor)?

[dantleech]

Yes, you're right 👍