Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent path resolution #1072

Open
dantleech opened this issue Dec 21, 2023 · 0 comments
Open

Inconsistent path resolution #1072

dantleech opened this issue Dec 21, 2023 · 0 comments

Comments

@dantleech
Copy link
Member

dantleech commented Dec 21, 2023

Some paths are relative to the config, while others to the CWD:

  "$schema": "vendor/phpbench/phpbench/phpbench.schema.json",
  "runner.path": "../../tests/Benchmark",
  "runner.bootstrap": "phpbench-bootstrap.php",
  "runner.file_pattern": "*Bench.php",
  "storage.xml_storage_path": ".tools/phpbench/data/storage",
  "report.outputs": {
    "html": {
      "renderer": "html",
      "title": "Benchmarks",
      "path": ".tools/phpbench/data/html/index.html"
    }
  }

Suggest to fix this in 2.0 and make them all relative to the config file in which they are defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant