Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot filter by variant with spaces #1067

Open
dantleech opened this issue Dec 18, 2023 · 1 comment
Open

Cannot filter by variant with spaces #1067

dantleech opened this issue Dec 18, 2023 · 1 comment
Labels

Comments

@dantleech
Copy link
Member

$ phpbench run --variant="expense is"
Warning: Neither SSH agent or COMPOSER_AUTH is configured. Private repositories would not be accessible.
-->  DEVELOPMENT MODE    TESTING MODE
PHPBench (1.2.14) running benchmarks... #standwithukraine
with configuration file: /data/phpbench.json
with PHP version 8.2.9, xdebug ❌, opcache ✔


In BenchmarkFinder.php line 105:

  File or directory "/data/is" does not exist (cwd: /data)

@dantleech dantleech added the bug label Dec 18, 2023
@jbboehr
Copy link
Contributor

jbboehr commented Apr 9, 2024

That's the behavior I would expect if the argument wasn't quoted:

$ ./bin/phpbench run --variant=expense is
PHPBench (dev-master) running benchmarks... #standwithukraine
with configuration file: /home/user/phpbench/phpbench.json
with PHP version 8.2.16, xdebug ❌, opcache ❌


In BenchmarkFinder.php line 88:
                                                                                                
  File or directory "/home/user/phpbench/is" does not exist (cwd: /home/user/phpbench)

When it's quoted it seems to not error:

$ ./bin/phpbench run --variant="expense is"
PHPBench (dev-master) running benchmarks... #standwithukraine
with configuration file: /home/user/phpbench/phpbench.json
with PHP version 8.2.16, xdebug ❌, opcache ❌

\PhpBench\Tests\Benchmark\Data\DataFrameBench


\PhpBench\Tests\Benchmark\Report\Generator\ExpressionGeneratorBench

[...]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants