-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing a notice before the benchmark #1003
Comments
Not sure what you mean? What's the use case? |
For example our benchmarks are heavily skewed if New Relic is enabled. I was thinking of showing a warning. |
Not really, you can add an "environment" sampler to add some env data which you could use in a Report: https://github.com/phpbench/phpbench/blob/master/lib/Environment/Provider/Php.php |
and you could add a custom progress logger that could show a warning, but maybe overkill (the env data is in phpbench/lib/Progress/Logger/PhpBenchLogger.php Lines 65 to 70 in 236a040
|
2 similar comments
and you could add a custom progress logger that could show a warning, but maybe overkill (the env data is in phpbench/lib/Progress/Logger/PhpBenchLogger.php Lines 65 to 70 in 236a040
|
and you could add a custom progress logger that could show a warning, but maybe overkill (the env data is in phpbench/lib/Progress/Logger/PhpBenchLogger.php Lines 65 to 70 in 236a040
|
That is a bit overkill. Any chance you want to add New Relic to the Xdebug/Opcache list? It has a significant performant impact when running benchmarks. |
Maybe , although needs more thought. What is there is a bit hacky, and wouldn't want to show "New Relic" on each run as we with XDebug/OPCache. |
Is there any mechanism to show a colonized notice/warning once before executing any test?
The text was updated successfully, but these errors were encountered: