Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion filtering incorrectly filters static calls. #2603

Closed
dantleech opened this issue Mar 16, 2024 · 1 comment
Closed

Suggestion filtering incorrectly filters static calls. #2603

dantleech opened this issue Mar 16, 2024 · 1 comment
Labels

Comments

@dantleech
Copy link
Collaborator

dantleech commented Mar 16, 2024

Currently we would filter class suggestions for classes which are compatible with the parameter type, however often we may want to use a factory to create the parameter type, which is also a class, e.g. $layout->constraints(ConstraintFactrory::percentage(50)). Currently ConstraintFactory would not be suggested.

In general:

  • if we are making a static call then it's better to show all class results.
  • unless we further filter to classes with static mehods that return the wanted class.
@dantleech dantleech changed the title Context sensitive class filtering issue Suggestion filtering incorrectly filters static calls. Mar 16, 2024
@dantleech dantleech added the bug label Mar 29, 2024
@dantleech
Copy link
Collaborator Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant